[FSSDK-11172] feat: update decision service to handle CMAB #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # OptimizelySwiftSDK.xcodeproj/project.pbxproj # Sources/CMAB/CmabClient.swift # Tests/OptimizelyTests-Common/CMABClientTests.swift
# Conflicts: # Sources/CMAB/CmabService.swift # Tests/OptimizelyTests-Common/CmabServiceTests.swift
jaeopt
requested changes
Jul 4, 2025
|
|
||
| extension DefaultCmabService { | ||
| static func createDefault() -> DefaultCmabService { | ||
| let DEFAULT_CMAB_CACHE_TIMEOUT = 30 * 60 * 1000 // 30 minutes in milliseconds |
There was a problem hiding this comment.
Looks like this timeout is too large - is this consistent for all SDKs? @raju-opti
Comment on lines
+48
to
52
| if !mutexAllowed { | ||
| return DecisionResponse(result: nil, reasons: reasons) | ||
| } | ||
|
|
||
| if !mutexAllowed { return DecisionResponse(result: nil, reasons: reasons) } |
There was a problem hiding this comment.
Yes, reuse the mutex logic.
|
|
||
| var cmabDecision: CmabDecision? | ||
| /// Fetch CMAB decision | ||
| let response = cmabService.getDecision(config: config, userContext: user, ruleId: experiment.id, options: options ?? []) |
There was a problem hiding this comment.
This is blocking call. Is it ok?
| return | ||
| } | ||
|
|
||
| let decision = self.decide(user: user, keys: config.featureFlagKeys, options: options, opType: .async, ignoreDefaultOptions: false) |
There was a problem hiding this comment.
why "ignoreDefaultOptions=false" here? Not consistent with sync version above?
Comment on lines
+98
to
+103
| guard opType == .async else { | ||
| let info = LogMessage.cmabNotSupportedInSyncMode | ||
| logger.w(info) | ||
| reasons.addInfo(info) | ||
| return DecisionResponse(result: nil, reasons: reasons) | ||
| } |
There was a problem hiding this comment.
Can we check if running thread, and reject if main thread?
CMAB can be called in sync decide inside of background thread?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues