Skip to content

Commit 7a56d47

Browse files
muzahidul-optimuzahidul-opti
committed
wip: rename api
1 parent 793d1d5 commit 7a56d47

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

‎Tests/OptimizelyTests-Common/DecisionListenerTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1263,7 +1263,7 @@ class FakeDecisionService: DefaultDecisionService {
12631263
return DecisionResponse.responseNoReasons(result: featureDecision)
12641264
}
12651265

1266-
override func getVariationForFeatureExperiment(config: ProjectConfig, featureFlag: FeatureFlag, user: OptimizelyUserContext, userProfileTracker: UserProfileTracker? = nil, options: [OptimizelyDecideOption]? = nil) -> DecisionResponse<FeatureDecision> {
1266+
override func getVariationForFeature(config: ProjectConfig, featureFlag: FeatureFlag, user: OptimizelyUserContext, userProfileTracker: UserProfileTracker? = nil, options: [OptimizelyDecideOption]? = nil) -> DecisionResponse<FeatureDecision> {
12671267
guard let experiment = self.experiment, let tmpVariation = self.variation else {
12681268
return DecisionResponse.nilNoReasons()
12691269
}

‎Tests/OptimizelyTests-Common/DecisionServiceTests_Features.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ class DecisionServiceTests_Features: XCTestCase {
258258
extension DecisionServiceTests_Features {
259259

260260
func testGetVariationForFeatureExperimentWhenMatched() {
261-
let pair = self.decisionService.getVariationForFeatureExperiment(config: config,
261+
let pair = self.decisionService.getVariationForFeature(config: config,
262262
featureFlag: featureFlag,
263263
user: optimizely.createUserContext(userId: kUserId,
264264
attributes: kAttributesCountryMatch)).result
@@ -268,7 +268,7 @@ extension DecisionServiceTests_Features {
268268
}
269269

270270
func testGetVariationForFeatureExperimentWhenNotMatched() {
271-
let pair = self.decisionService.getVariationForFeatureExperiment(config: config,
271+
let pair = self.decisionService.getVariationForFeature(config: config,
272272
featureFlag: featureFlag,
273273
user: optimizely.createUserContext(userId: kUserId,
274274
attributes: kAttributesCountryNotMatch)).result
@@ -280,7 +280,7 @@ extension DecisionServiceTests_Features {
280280
featureFlag.experimentIds = ["99999"] // not-existing experiment
281281
self.config.project.featureFlags = [featureFlag]
282282

283-
let pair = self.decisionService.getVariationForFeatureExperiment(config: config,
283+
let pair = self.decisionService.getVariationForFeature(config: config,
284284
featureFlag: featureFlag,
285285
user: optimizely.createUserContext(userId: kUserId,
286286
attributes: kAttributesCountryMatch)).result

‎Tests/OptimizelyTests-Common/DecisionServiceTests_Features_Holdouts.swift

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
220220
// Mock bucketer to ensure user is bucketed into holdout variation
221221
let mockBucketer = MockBucketer(mockBucketValue: 500) // Within holdout range (0-1000)
222222
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
223-
let decision = mockDecisionService.getVariationForFeatureExperiment(
223+
let decision = mockDecisionService.getVariationForFeature(
224224
config: config,
225225
featureFlag: featureFlag,
226226
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)
@@ -237,7 +237,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
237237
let mockBucketer = MockBucketer(mockBucketValue: 500) // Within holdout range
238238
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
239239

240-
let decision = mockDecisionService.getVariationForFeatureExperiment(
240+
let decision = mockDecisionService.getVariationForFeature(
241241
config: config,
242242
featureFlag: featureFlag,
243243
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryNotMatch)
@@ -252,7 +252,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
252252
let mockBucketer = MockBucketer(mockBucketValue: 1500) // Outside holdout range (0-1000)
253253
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
254254

255-
let decision = mockDecisionService.getVariationForFeatureExperiment(
255+
let decision = mockDecisionService.getVariationForFeature(
256256
config: config,
257257
featureFlag: featureFlag,
258258
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)
@@ -277,7 +277,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
277277
let mockBucketer = MockBucketer(mockBucketValue: 500) // Would bucket in holdout if active
278278
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
279279

280-
let decision = mockDecisionService.getVariationForFeatureExperiment(
280+
let decision = mockDecisionService.getVariationForFeature(
281281
config: config,
282282
featureFlag: featureFlag,
283283
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)
@@ -299,7 +299,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
299299
let mockBucketer = MockBucketer(mockBucketValue: 500)
300300
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
301301

302-
let decision = mockDecisionService.getVariationForFeatureExperiment(
302+
let decision = mockDecisionService.getVariationForFeature(
303303
config: config,
304304
featureFlag: featureFlag,
305305
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)
@@ -323,7 +323,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
323323
let mockBucketer = MockBucketer(mockBucketValue: 500) // Within holdout range
324324
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
325325

326-
let decision = mockDecisionService.getVariationForFeatureExperiment(
326+
let decision = mockDecisionService.getVariationForFeature(
327327
config: config,
328328
featureFlag: featureFlag,
329329
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)
@@ -347,7 +347,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
347347
let mockBucketer = MockBucketer(mockBucketValue: 500) // Within holdout range
348348
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
349349

350-
let decision = mockDecisionService.getVariationForFeatureExperiment(
350+
let decision = mockDecisionService.getVariationForFeature(
351351
config: config,
352352
featureFlag: featureFlag,
353353
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)
@@ -372,7 +372,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
372372
let mockBucketer = MockBucketer(mockBucketValue: 500)
373373
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
374374

375-
let decision = mockDecisionService.getVariationForFeatureExperiment(
375+
let decision = mockDecisionService.getVariationForFeature(
376376
config: config,
377377
featureFlag: featureFlag,
378378
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)
@@ -403,7 +403,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
403403
let mockBucketer = MockBucketer(mockBucketValue: 1000) // Within all holdout ranges
404404
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
405405

406-
let decision = mockDecisionService.getVariationForFeatureExperiment(
406+
let decision = mockDecisionService.getVariationForFeature(
407407
config: config,
408408
featureFlag: featureFlag,
409409
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)
@@ -428,7 +428,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
428428
let mockBucketer = MockBucketer(mockBucketValue: 700) // Outside global range, within included range
429429
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
430430

431-
let decision = mockDecisionService.getVariationForFeatureExperiment(
431+
let decision = mockDecisionService.getVariationForFeature(
432432
config: config,
433433
featureFlag: featureFlag,
434434
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)
@@ -452,7 +452,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
452452
let mockBucketer = MockBucketer(mockBucketValue: 1500) // Outside all holdout ranges
453453
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
454454

455-
let decision = mockDecisionService.getVariationForFeatureExperiment(
455+
let decision = mockDecisionService.getVariationForFeature(
456456
config: config,
457457
featureFlag: featureFlag,
458458
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)
@@ -476,7 +476,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
476476
let mockBucketer = MockBucketer(mockBucketValue: 500)
477477
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
478478

479-
let decision = mockDecisionService.getVariationForFeatureExperiment(
479+
let decision = mockDecisionService.getVariationForFeature(
480480
config: config,
481481
featureFlag: featureFlag,
482482
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)
@@ -503,7 +503,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
503503
let mockBucketer = MockBucketer(mockBucketValue: 1500) // Outside included holdout range
504504
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
505505

506-
let decision = mockDecisionService.getVariationForFeatureExperiment(
506+
let decision = mockDecisionService.getVariationForFeature(
507507
config: config,
508508
featureFlag: featureFlag,
509509
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryNotMatch)
@@ -525,7 +525,7 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
525525
let mockBucketer = MockBucketer(mockBucketValue: 500)
526526
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
527527

528-
let decision = mockDecisionService.getVariationForFeatureExperiment(
528+
let decision = mockDecisionService.getVariationForFeature(
529529
config: config,
530530
featureFlag: featureFlag,
531531
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)
@@ -548,14 +548,14 @@ class DecisionServiceTests_Features_Holdouts: XCTestCase {
548548
let mockDecisionService = MockDecisionService(bucketer: mockBucketer, userProfileService: decisionService.userProfileService)
549549

550550
// First call
551-
let decision1 = mockDecisionService.getVariationForFeatureExperiment(
551+
let decision1 = mockDecisionService.getVariationForFeature(
552552
config: config,
553553
featureFlag: featureFlag,
554554
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)
555555
).result
556556

557557
// Second call with same inputs
558-
let decision2 = mockDecisionService.getVariationForFeatureExperiment(
558+
let decision2 = mockDecisionService.getVariationForFeature(
559559
config: config,
560560
featureFlag: featureFlag,
561561
user: optimizely.createUserContext(userId: kUserId, attributes: kAttributesCountryMatch)

0 commit comments

Comments
 (0)