wip: DecisionService testcases added for holdouts

Author: muzahidul-opti

OptimizelySwiftSDK.xcodeproj/project.pbxproj

@@ -2054,6 +2054,8 @@
 		98AC97F42DAE9685001405DD /* HoldoutConfigTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 98AC97F22DAE9685001405DD /* HoldoutConfigTests.swift */; };
 		98AC98462DB7B762001405DD /* BucketTests_HoldoutToVariation.swift in Sources */ = {isa = PBXBuildFile; fileRef = 98AC98452DB7B762001405DD /* BucketTests_HoldoutToVariation.swift */; };
 		98AC98472DB7B762001405DD /* BucketTests_HoldoutToVariation.swift in Sources */ = {isa = PBXBuildFile; fileRef = 98AC98452DB7B762001405DD /* BucketTests_HoldoutToVariation.swift */; };
+		98AC98492DB8FC29001405DD /* DecisionServiceTests_Features_Holdouts.swift in Sources */ = {isa = PBXBuildFile; fileRef = 98AC98482DB8FC29001405DD /* DecisionServiceTests_Features_Holdouts.swift */; };
+		98AC984B2DB8FFE0001405DD /* DecisionServiceTests_Features_Holdouts.swift in Sources */ = {isa = PBXBuildFile; fileRef = 98AC98482DB8FC29001405DD /* DecisionServiceTests_Features_Holdouts.swift */; };
 		BD1C3E8524E4399C0084B4DA /* SemanticVersion.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0B97DD93249D327F003DE606 /* SemanticVersion.swift */; };
 		BD64853C2491474500F30986 /* Optimizely.h in Headers */ = {isa = PBXBuildFile; fileRef = 6E75167A22C520D400B2B157 /* Optimizely.h */; settings = {ATTRIBUTES = (Public, ); }; };
 		BD64853E2491474500F30986 /* Audience.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6E75169822C520D400B2B157 /* Audience.swift */; };
@@ -2500,6 +2502,7 @@
 		98AC97E12DAE4579001405DD /* HoldoutConfig.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HoldoutConfig.swift; sourceTree = "<group>"; };
 		98AC97F22DAE9685001405DD /* HoldoutConfigTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HoldoutConfigTests.swift; sourceTree = "<group>"; };
 		98AC98452DB7B762001405DD /* BucketTests_HoldoutToVariation.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BucketTests_HoldoutToVariation.swift; sourceTree = "<group>"; };
+		98AC98482DB8FC29001405DD /* DecisionServiceTests_Features_Holdouts.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DecisionServiceTests_Features_Holdouts.swift; sourceTree = "<group>"; };
 		BD6485812491474500F30986 /* Optimizely.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Optimizely.framework; sourceTree = BUILT_PRODUCTS_DIR; };
 		C78CAF572445AD8D009FE876 /* OptimizelyJSON.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OptimizelyJSON.swift; sourceTree = "<group>"; };
 		C78CAF652446DB91009FE876 /* OptimizelyClientTests_OptimizelyJSON.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OptimizelyClientTests_OptimizelyJSON.swift; sourceTree = "<group>"; };
@@ -3015,6 +3018,7 @@
 				6E27ECBD266FD78600B4A6D4 /* DecisionReasonsTests.swift */,
 				6E75198022C5211100B2B157 /* DecisionServiceTests_Experiments.swift */,
 				6E75199122C5211100B2B157 /* DecisionServiceTests_Features.swift */,
+				98AC98482DB8FC29001405DD /* DecisionServiceTests_Features_Holdouts.swift */,
 				6E75199422C5211100B2B157 /* DecisionServiceTests_Others.swift */,
 				6E75198622C5211100B2B157 /* DecisionServiceTests_UserProfiles.swift */,
 				6E75198822C5211100B2B157 /* DefaultLoggerTests.swift */,
@@ -4988,6 +4992,7 @@
 				6E7516F722C520D400B2B157 /* OptimizelyError.swift in Sources */,
 				84861812286D0B8900B7F41B /* OdpSegmentManagerTests.swift in Sources */,
 				6E75189122C520D400B2B157 /* Project.swift in Sources */,
+				98AC98492DB8FC29001405DD /* DecisionServiceTests_Features_Holdouts.swift in Sources */,
 				6E7517F522C520D400B2B157 /* DataStoreMemory.swift in Sources */,
 				6E0207A9272A11CF008C3711 /* NetworkReachabilityTests.swift in Sources */,
 				6E75183D22C520D400B2B157 /* EventForDispatch.swift in Sources */,
@@ -5340,6 +5345,7 @@
 				6EF8DE2124BD1BB2008B9488 /* OptimizelyDecideOption.swift in Sources */,
 				8464087928130D3200CCF97D /* Integration.swift in Sources */,
 				6E9B118122C5488100C22D81 /* ConditionLeafTests.swift in Sources */,
+				98AC984B2DB8FFE0001405DD /* DecisionServiceTests_Features_Holdouts.swift in Sources */,
 				6E75184522C520D400B2B157 /* Event.swift in Sources */,
 				6E75191122C520D500B2B157 /* BackgroundingCallbacks.swift in Sources */,
 				848617D12863DC2700B7F41B /* OdpSegmentManager.swift in Sources */,

Sources/Implementation/DefaultBucketer.swift

@@ -150,7 +150,6 @@ class DefaultBucketer: OPTBucketer {
     }
 
     func allocateTraffic(trafficAllocation: [TrafficAllocation], bucketValue: Int) -> String? {
-        print("Bucketed value \(bucketValue)")
         for bucket in trafficAllocation where bucketValue < bucket.endOfRange {
             return bucket.entityId
         }

Sources/Implementation/DefaultDecisionService.swift

@@ -42,6 +42,11 @@ class DefaultDecisionService: OPTDecisionService {
         self.userProfileService = userProfileService
     }
 
+    init(userProfileService: OPTUserProfileService, bucketer: OPTBucketer) {
+        self.bucketer = bucketer
+        self.userProfileService = userProfileService
+    }
+    
     /// Public Method
     func getVariation(config: ProjectConfig,
                       experiment: Experiment,
@@ -280,6 +285,7 @@ class DefaultDecisionService: OPTDecisionService {
                                           options: [OptimizelyDecideOption]? = nil) -> DecisionResponse<FeatureDecision> {
         let reasons = DecisionReasons(options: options)
         let holdouts = config.getHoldoutForFlag(id: featureFlag.id)
+        
         for holdout in holdouts {
             let dicisionResponse = getVariationForHoldout(config: config,
                                                           flagKey: featureFlag.key,