-
Notifications
You must be signed in to change notification settings - Fork 28
[FSSDK-11459] Ruby - Add SDK Multi-Region Support for Data Hosting #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
esrakartalOpt
wants to merge
21
commits into
master
Choose a base branch
from
esra/FSSDK-11459_eu_hosting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0165dee
[FSSDK-11459] Ruby - Add SDK Multi-Region Support for Data Hosting
esrakartalOpt 73769f1
Fix lint issues
esrakartalOpt f9156d0
Fix lint
esrakartalOpt a5e6faf
Fix test
esrakartalOpt 9f47706
Add with region
esrakartalOpt e776ead
Fix lint
esrakartalOpt 884c972
Fix lint issue
esrakartalOpt 6d0245e
Correct the Region default value
esrakartalOpt e1ae8b5
Fix failed tests
esrakartalOpt c8a47b1
Fix lint
esrakartalOpt 93e7a11
Fix test cases
esrakartalOpt 06295e6
Fix event builder
esrakartalOpt 04e3a7e
Fix the issue
esrakartalOpt 474d01d
Fix typo
esrakartalOpt ae26ced
Correct the event name
esrakartalOpt 80d0c16
Fix errors
esrakartalOpt fd72f77
Fix errors
esrakartalOpt 4dea3ec
Fix test cases
esrakartalOpt 904d0bd
Fix test cases
esrakartalOpt 7f98564
Implement copilot review comments
esrakartalOpt 56bc8cd
Fix lint
esrakartalOpt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
region
method is currently a stub and returns nothing. It should return the instance variable, e.g.,def region; @region; end
.Copilot uses AI. Check for mistakes.