Skip to content

Fix typing on ctl.utils #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix typing on ctl.utils #92

merged 1 commit into from
Oct 17, 2024

Conversation

ogenstad
Copy link
Contributor

Also fixes #56.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/ctl/utils.py 63.63% 4 Missing ⚠️
@@             Coverage Diff             @@
##           develop      #92      +/-   ##
===========================================
- Coverage    64.26%   64.24%   -0.02%     
===========================================
  Files           74       74              
  Lines         6858     6861       +3     
  Branches      1356     1356              
===========================================
+ Hits          4407     4408       +1     
- Misses        2099     2101       +2     
  Partials       352      352              
Flag Coverage Δ
python-3.10 43.21% <63.63%> (-0.01%) ⬇️
python-3.11 43.21% <63.63%> (-0.01%) ⬇️
python-3.12 43.21% <63.63%> (-0.01%) ⬇️
python-3.9 43.15% <63.63%> (-0.01%) ⬇️
python-filler-3.12 23.90% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/utils.py 60.29% <63.63%> (-0.61%) ⬇️

@ogenstad ogenstad marked this pull request as ready for review October 17, 2024 17:26
@ogenstad ogenstad requested a review from a team October 17, 2024 17:26
@ogenstad ogenstad merged commit e4b8cd5 into develop Oct 17, 2024
12 checks passed
@ogenstad ogenstad deleted the pog-typing-utils branch October 17, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Fix broken debug section(s)
2 participants