Skip to content

Fix typehints and remove type ignores for ctl.importer & ctl.exporter #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

ogenstad
Copy link
Contributor

This change also highlighted an issue as we were still running aiorun to get the client.

This change also highlighted an issue as we were still running aiorun to
get the client.
@ogenstad ogenstad changed the title Fix typehints and remove type ignores for ctl.importer Fix typehints and remove type ignores for ctl.importer & ctl.exporter Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/ctl/exporter.py 50.00% 1 Missing ⚠️
infrahub_sdk/ctl/importer.py 50.00% 1 Missing ⚠️
@@           Coverage Diff            @@
##           develop      #91   +/-   ##
========================================
  Coverage    64.26%   64.26%           
========================================
  Files           74       74           
  Lines         6858     6858           
  Branches      1356     1356           
========================================
  Hits          4407     4407           
  Misses        2099     2099           
  Partials       352      352           
Flag Coverage Δ
python-3.10 43.21% <50.00%> (ø)
python-3.11 43.21% <50.00%> (ø)
python-3.12 43.21% <50.00%> (ø)
python-3.9 43.16% <50.00%> (ø)
python-filler-3.12 23.91% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/exporter.py 52.17% <50.00%> (ø)
infrahub_sdk/ctl/importer.py 55.00% <50.00%> (ø)

@ogenstad ogenstad marked this pull request as ready for review October 17, 2024 17:17
@ogenstad ogenstad requested a review from a team October 17, 2024 17:27
@ogenstad ogenstad merged commit fad05dc into develop Oct 17, 2024
12 checks passed
@ogenstad ogenstad deleted the pog-ctl-importer branch October 17, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants