Skip to content

Run coverage separately #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Run coverage separately #79

merged 1 commit into from
Oct 15, 2024

Conversation

ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Oct 15, 2024

Runs "coverage" as a separate task in order to get around problems with our own pytest plugin being loaded before pytest-cov starts to calculate coverage which causes the parts of our files that get auto imported to be marked as missed in the coverage report.

@dgarros, this was what I had in mind. Should also work fine with regards to xdist etc.

@github-actions github-actions bot added the group/ci Issue related to the CI pipeline label Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff              @@
##           develop      #79       +/-   ##
============================================
+ Coverage    43.28%   64.62%   +21.33%     
============================================
  Files           74       78        +4     
  Lines         6847     6917       +70     
  Branches      1353     1357        +4     
============================================
+ Hits          2964     4470     +1506     
+ Misses        3552     2095     -1457     
- Partials       331      352       +21     
Flag Coverage Δ
python-3.10 43.28% <ø> (ø)
python-3.11 43.28% <ø> (ø)
python-3.12 43.28% <ø> (ø)
python-3.9 43.23% <ø> (ø)
python-filler-3.12 36.83% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 44 files with indirect coverage changes

@ogenstad ogenstad force-pushed the pog-coverage branch 2 times, most recently from 3a4ccfe to 0db4201 Compare October 15, 2024 06:28
@ogenstad ogenstad marked this pull request as ready for review October 15, 2024 06:43
@ogenstad ogenstad merged commit 2bb8bec into develop Oct 15, 2024
12 checks passed
@ogenstad ogenstad deleted the pog-coverage branch October 15, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/ci Issue related to the CI pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants