Skip to content

Fix broken SDK playback #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix broken SDK playback #72

merged 1 commit into from
Oct 14, 2024

Conversation

ogenstad
Copy link
Contributor

Fixes #64

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/playback.py 0.00% 2 Missing ⚠️
@@             Coverage Diff             @@
##           develop      #72      +/-   ##
===========================================
- Coverage    43.07%   43.07%   -0.01%     
===========================================
  Files           70       70              
  Lines         6653     6654       +1     
  Branches      1307     1307              
===========================================
  Hits          2866     2866              
- Misses        3456     3457       +1     
  Partials       331      331              
Flag Coverage Δ
python-3.10 43.07% <0.00%> (-0.01%) ⬇️
python-3.11 43.07% <0.00%> (-0.01%) ⬇️
python-3.12 43.07% <0.00%> (-0.01%) ⬇️
python-3.9 43.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/playback.py 0.00% <0.00%> (ø)

@ogenstad ogenstad marked this pull request as ready for review October 14, 2024 07:37
@ogenstad ogenstad requested a review from a team October 14, 2024 07:37
@ogenstad ogenstad merged commit d03e036 into develop Oct 14, 2024
12 checks passed
@ogenstad ogenstad deleted the pog-fix-playback branch October 14, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: replay recorded SDK session leads to FileNotFoundError exception being raised
2 participants