-
Notifications
You must be signed in to change notification settings - Fork 6
Support all attributes kind in protocols #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@dgarros I added the support for The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not quite sure about the implementation here:
Example generated: class ExampleFullAttributesNode(CoreNode):
id_required: IDAttribute
id_optional: IDAttributeOptional
text_required: TextAttribute
text_optional: TextAttributeOptional
textarea_required: TextAreaAttribute
textarea_optional: TextAreaAttributeOptional
datetime_required: DateTimeAttribute
datetime_optional: DateTimeAttributeOptional
email_required: EmailAttribute
email_optional: EmailAttributeOptional
password_required: PasswordAttribute
password_optional: PasswordAttributeOptional
hashed_password_required: HashedPasswordAttribute
hashed_password_optional: HashedPasswordAttributeOptional
url_required: URLAttribute
url_optional: URLAttributeOptional
file_required: FileAttribute
file_optional: FileAttributeOptional
mac_address_required: MacAddressAttribute
mac_address_optional: MacAddressAttributeOptional
color_required: ColorAttribute
color_optional: ColorAttributeOptional
number_required: NumberAttribute
number_optional: NumberAttributeOptional
bandwidth_required: BandwidthAttribute
bandwidth_optional: BandwidthAttributeOptional
ip_host_required: IPHostAttribute
ip_host_optional: IPHostAttributeOptional
ip_network_required: IPNetworkAttribute
ip_network_optional: IPNetworkAttributeOptional
boolean_required: BooleanAttribute
boolean_optional: BooleanAttributeOptional
checkbox_required: CheckboxAttribute
checkbox_optional: CheckboxAttributeOptional
list_required: ListAttribute
list_optional: ListAttributeOptional
json_required: JSONAttribute
json_optional: JSONAttributeOptional
any_required: AnyAttribute
any_optional: AnyAttributeOptional
dropdown_required: DropdownAttribute
dropdown_optional: DropdownAttributeOptional
profiles: RelationshipManager
member_of_groups: RelationshipManager
subscriber_of_groups: RelationshipManager |
|
This came up today with another deployment, so would be great to finish this off and make a new SDK build asap. FYI @wvandeun |
relates #57