Skip to content

Merge stable into develop #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025
Merged

Merge stable into develop #428

merged 3 commits into from
Jun 5, 2025

Conversation

infrahub-github-bot-app[bot]
Copy link

Merging stable into develop after merging pull request #425.

* utils.py: update file not found exception message

Previous message implies the file is found but the contents are not valid. Especially when referring to a YAML file.

This adds a clearer message and specifies where the code has looked for the file.

* utils.py: read_file - change argument name

Clearer argument name and use of path object

* repository.py: param signature change

Downstream method changed signature:
file_name --> file_path

* Update test_yaml.py

Fix test_missing_file after error message change

* Update test_yaml.py

Use correct variable name

* ruff formatting

* utils.py: read_file - use parent instead of cwd

* Update test_yaml.py

Update incorrect encoding test after read_file method changes.

* ruff formatting
Copy link

cloudflare-workers-and-pages bot commented Jun 4, 2025

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8a7b833
Status: ✅  Deploy successful!
Preview URL: https://b4a4668e.infrahub-sdk-python.pages.dev

View logs

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop     #428      +/-   ##
===========================================
+ Coverage    75.13%   76.18%   +1.04%     
===========================================
  Files          100      101       +1     
  Lines         8620    10761    +2141     
  Branches      1691     2302     +611     
===========================================
+ Hits          6477     8198    +1721     
- Misses        1678     1937     +259     
- Partials       465      626     +161     
Flag Coverage Δ
integration-tests 35.66% <33.33%> (+1.46%) ⬆️
python-3.10 49.14% <83.33%> (+1.93%) ⬆️
python-3.11 49.16% <83.33%> (+1.92%) ⬆️
python-3.12 49.14% <83.33%> (+1.93%) ⬆️
python-3.13 49.14% <83.33%> (+1.93%) ⬆️
python-3.9 47.75% <66.66%> (+2.22%) ⬆️
python-filler-3.12 23.78% <16.66%> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/repository.py 81.81% <100.00%> (ø)
infrahub_sdk/utils.py 81.54% <100.00%> (ø)

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad merged commit 82b5e1c into develop Jun 5, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants