-
Notifications
You must be signed in to change notification settings - Fork 6
Add objects field within InfrahubConfig #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying infrahub-sdk-python with
|
Latest commit: |
6377bcd
|
Status: | ✅ Deploy successful! |
Preview URL: | https://8c8546e5.infrahub-sdk-python.pages.dev |
Branch Preview URL: | https://lgu-repo-object-config.infrahub-sdk-python.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #422 +/- ##
===========================================
+ Coverage 75.14% 75.38% +0.23%
===========================================
Files 100 100
Lines 8614 8705 +91
Branches 1689 1691 +2
===========================================
+ Hits 6473 6562 +89
- Misses 1677 1678 +1
- Partials 464 465 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
785487d
to
0b131fb
Compare
@@ -48,6 +48,7 @@ def schema_person_base(self) -> NodeSchema: | |||
namespace=NAMESPACE, | |||
include_in_menu=True, | |||
label="Person", | |||
default_filter="name__value", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this because TestProposeChangeRepository
imports the git repository which loads the data where peers are referenced using notation "John Doe"
, which does not work when default_filter is not set on the schema. We use this notation instead of the hfid notation [John Doe] because backend tests also import the repository but with schemas only defining default_filter
. If above schema is meant to be used by users, it would probably be cleaner to define the hfid on backend tests schemas and use hfid notation, but these schemas are used by a lot of tests so there is a risk that some tests break.
b8a7cb4
to
bc1de9d
Compare
bc1de9d
to
6377bcd
Compare
No description provided.