Skip to content

Add objects field within InfrahubConfig #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

Conversation

LucasG0
Copy link
Contributor

@LucasG0 LucasG0 commented May 23, 2025

No description provided.

Copy link

cloudflare-workers-and-pages bot commented May 23, 2025

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6377bcd
Status: ✅  Deploy successful!
Preview URL: https://8c8546e5.infrahub-sdk-python.pages.dev
Branch Preview URL: https://lgu-repo-object-config.infrahub-sdk-python.pages.dev

View logs

Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop     #422      +/-   ##
===========================================
+ Coverage    75.14%   75.38%   +0.23%     
===========================================
  Files          100      100              
  Lines         8614     8705      +91     
  Branches      1689     1691       +2     
===========================================
+ Hits          6473     6562      +89     
- Misses        1677     1678       +1     
- Partials       464      465       +1     
Flag Coverage Δ
integration-tests 34.72% <87.50%> (+0.52%) ⬆️
python-3.10 47.61% <85.22%> (+0.39%) ⬆️
python-3.11 47.63% <85.22%> (+0.41%) ⬆️
python-3.12 47.59% <85.22%> (+0.39%) ⬆️
python-3.13 47.61% <85.22%> (+0.41%) ⬆️
python-3.9 45.94% <85.22%> (+0.40%) ⬆️
python-filler-3.12 24.49% <13.63%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/client.py 69.55% <ø> (-0.25%) ⬇️
infrahub_sdk/protocols.py 100.00% <100.00%> (ø)
infrahub_sdk/query_groups.py 60.30% <100.00%> (+0.93%) ⬆️
infrahub_sdk/schema/repository.py 87.24% <100.00%> (+0.91%) ⬆️
infrahub_sdk/spec/object.py 84.78% <100.00%> (ø)
infrahub_sdk/testing/schemas/car_person.py 81.41% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucasG0 LucasG0 force-pushed the lgu-repo-object-config branch 4 times, most recently from 785487d to 0b131fb Compare May 26, 2025 11:39
@@ -48,6 +48,7 @@ def schema_person_base(self) -> NodeSchema:
namespace=NAMESPACE,
include_in_menu=True,
label="Person",
default_filter="name__value",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this because TestProposeChangeRepository imports the git repository which loads the data where peers are referenced using notation "John Doe", which does not work when default_filter is not set on the schema. We use this notation instead of the hfid notation [John Doe] because backend tests also import the repository but with schemas only defining default_filter. If above schema is meant to be used by users, it would probably be cleaner to define the hfid on backend tests schemas and use hfid notation, but these schemas are used by a lot of tests so there is a risk that some tests break.

@LucasG0 LucasG0 marked this pull request as ready for review May 26, 2025 11:50
@LucasG0 LucasG0 requested a review from a team May 26, 2025 11:51
@LucasG0 LucasG0 force-pushed the lgu-repo-object-config branch 2 times, most recently from b8a7cb4 to bc1de9d Compare May 26, 2025 12:17
@LucasG0 LucasG0 force-pushed the lgu-repo-object-config branch from bc1de9d to 6377bcd Compare May 26, 2025 12:18
@LucasG0 LucasG0 merged commit f414027 into develop May 26, 2025
19 checks passed
@LucasG0 LucasG0 deleted the lgu-repo-object-config branch May 26, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants