Trigger markdown lint on github action updates & fix rules #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying infrahub-sdk-python with
|
| Latest commit: |
f6f7842
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c4053b09.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-fix-markdownlint.infrahub-sdk-python.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #419 +/- ##
========================================
Coverage 75.16% 75.16%
========================================
Files 100 100
Lines 8613 8613
Branches 1689 1689
========================================
Hits 6474 6474
Misses 1676 1676
Partials 463 463
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
gmazoyer
approved these changes
May 21, 2025
.markdownlint.yaml
Outdated
| @@ -11,3 +11,5 @@ MD034: false # no-bare-urls | |||
| MD041: false # allow 1st line to not be a top-level heading (required for Towncrier) | |||
| MD045: false # no alt text around images | |||
| MD047: false # single trailing newline | |||
| MD059: # Link descriptions that are provibited | |||
ogenstad
force-pushed
the
pog-fix-markdownlint
branch
from
d6ff058 to
f6f7842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the CI where we upgraded markdown lint in #414, but the CI wasn't configured to run the markdown job during such an upgrade.
Now we see failures as there are violations based on the new rules from markdown lint. Which have to do with the text of anchor links.
The second update is to update the ruleset to ignore these new violations, we can go back later and re apply them again if desired.