Skip to content

Refresh python packages #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: stable
Choose a base branch
from
Open

Refresh python packages #415

wants to merge 4 commits into from

Conversation

BeArchiTek
Copy link
Contributor

No description provided.

Copy link

cloudflare-workers-and-pages bot commented May 20, 2025

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 174e8ec
Status: ✅  Deploy successful!
Preview URL: https://8b32d715.infrahub-sdk-python.pages.dev
Branch Preview URL: https://bkr-fix-python.infrahub-sdk-python.pages.dev

View logs

Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 9.52381% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
infrahub_sdk/node.py 13.33% 10 Missing and 3 partials ⚠️
infrahub_sdk/transfer/importer/json.py 0.00% 4 Missing ⚠️
infrahub_sdk/ctl/repository.py 0.00% 1 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##           stable     #415      +/-   ##
==========================================
- Coverage   75.10%   75.06%   -0.05%     
==========================================
  Files          93       93              
  Lines        8560     8581      +21     
  Branches     1678     1288     -390     
==========================================
+ Hits         6429     6441      +12     
- Misses       1677     1694      +17     
+ Partials      454      446       -8     
Flag Coverage Δ
integration-tests 34.40% <4.76%> (-0.03%) ⬇️
python-3.10 47.52% <9.52%> (+0.02%) ⬆️
python-3.11 47.50% <9.52%> (+<0.01%) ⬆️
python-3.12 47.52% <9.52%> (+0.02%) ⬆️
python-3.13 47.50% <9.52%> (+<0.01%) ⬆️
python-3.9 45.79% <9.52%> (-0.01%) ⬇️
python-filler-3.12 24.20% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/ctl/repository.py 79.74% <0.00%> (-2.08%) ⬇️
infrahub_sdk/transfer/importer/json.py 15.27% <0.00%> (-0.11%) ⬇️
infrahub_sdk/node.py 77.54% <13.33%> (-0.85%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BeArchiTek BeArchiTek self-assigned this May 21, 2025
@BeArchiTek BeArchiTek marked this pull request as ready for review May 21, 2025 09:15
@BeArchiTek BeArchiTek requested a review from a team May 21, 2025 09:15
@dgarros dgarros requested a review from ogenstad June 13, 2025 06:42
Copy link
Contributor

@ogenstad ogenstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a small comment regarding the change in pyproject.toml.

Also this PR has a merge conflict that needs to be resolved first. It looks like we're doing different things within this PR. Could we perhaps close this one and open two new ones, one for the package update and another one for the code changes and explain the changes with an issue or news fragment if needed?

@@ -32,7 +32,8 @@ ujson = "^5"
Jinja2 = { version = "^3", optional = true }
numpy = [
{ version = "^1.24.2", optional = true, python = ">=3.9,<3.12" },
{ version = "^1.26.2", optional = true, python = ">=3.12" },
{ version = "^1.26.2", optional = true, python = "==3.12" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely sure how this works. I.e. if ==3.12 would match any 3.12.x version or just 3.12.0. Do you know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants