-
Notifications
You must be signed in to change notification settings - Fork 6
Refresh python packages #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stable
Are you sure you want to change the base?
Conversation
Deploying infrahub-sdk-python with
|
Latest commit: |
174e8ec
|
Status: | ✅ Deploy successful! |
Preview URL: | https://8b32d715.infrahub-sdk-python.pages.dev |
Branch Preview URL: | https://bkr-fix-python.infrahub-sdk-python.pages.dev |
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## stable #415 +/- ##
==========================================
- Coverage 75.10% 75.06% -0.05%
==========================================
Files 93 93
Lines 8560 8581 +21
Branches 1678 1288 -390
==========================================
+ Hits 6429 6441 +12
- Misses 1677 1694 +17
+ Partials 454 446 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a small comment regarding the change in pyproject.toml.
Also this PR has a merge conflict that needs to be resolved first. It looks like we're doing different things within this PR. Could we perhaps close this one and open two new ones, one for the package update and another one for the code changes and explain the changes with an issue or news fragment if needed?
@@ -32,7 +32,8 @@ ujson = "^5" | |||
Jinja2 = { version = "^3", optional = true } | |||
numpy = [ | |||
{ version = "^1.24.2", optional = true, python = ">=3.9,<3.12" }, | |||
{ version = "^1.26.2", optional = true, python = ">=3.12" }, | |||
{ version = "^1.26.2", optional = true, python = "==3.12" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not completely sure how this works. I.e. if ==3.12
would match any 3.12.x version or just 3.12.0. Do you know?
No description provided.