-
Notifications
You must be signed in to change notification settings - Fork 66
🌱 OPRUN-4194: Allow openshift catalog versions to be configurable via helm #2264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 OPRUN-4194: Allow openshift catalog versions to be configurable via helm #2264
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/lgtm |
helm/olmv1/values.yaml
Outdated
enabled: false | ||
# This can be one of: standard or experimental | ||
featureSet: standard | ||
catalogVersion: v4.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about to make a struct like this:
catalog:
version: v4.20
it opens up a room for future extension without having long descriptive variable names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I did ponder that...
/hold |
Signed-off-by: Todd Short <tshort@redhat.com>
8cebfa4
to
d5c0eb7
Compare
/unhold |
enabled: false | ||
openshift: | ||
enabled: false | ||
catalogs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have mutiple catalogs with the same version or it should be
catalog:
version: v4.20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought of this... and it doesn't matter too much.
I put it under openshift
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, pedjak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2264 +/- ##
==========================================
+ Coverage 72.73% 73.06% +0.32%
==========================================
Files 89 88 -1
Lines 8747 8738 -9
==========================================
+ Hits 6362 6384 +22
+ Misses 1968 1942 -26
+ Partials 417 412 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
48d5ccd
into
operator-framework:main
Description
Reviewer Checklist