-
Notifications
You must be signed in to change notification settings - Fork 66
🐛 add rollingUpdate strategy #2263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 add rollingUpdate strategy #2263
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cluster_extension_install_test.go:1052: By eventually reporting Progressing == True with Reason Retrying
cluster_extension_install_test.go:1053:
Error Trace: /home/runner/work/operator-controller/operator-controller/test/e2e/cluster_extension_install_test.go:1058
/opt/hostedtoolcache/go/1.24.4/x64/src/runtime/asm_amd64.s:1700
Error: Not equal:
expected: "Retrying"
actual : "RolloutInProgress"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-Retrying
+RolloutInProgress
cluster_extension_install_test.go:1053:
Error Trace: /home/runner/work/operator-controller/operator-controller/test/e2e/cluster_extension_install_test.go:1053
Error: Condition never satisfied
Test: TestClusterExtensionRecoversFromExistingDeploymentWhenFailureFixed |
45a6cfe
to
c30436c
Compare
Signed-off-by: Jian Zhang <jiazha@redhat.com>
c30436c
to
9e5978e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2263 +/- ##
=======================================
Coverage 72.87% 72.87%
=======================================
Files 88 88
Lines 8733 8733
=======================================
Hits 6364 6364
Misses 1955 1955
Partials 414 414
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
687401c
into
operator-framework:main
Description
To address the issue: the cluster operator olm
Available=False
when cluster upgrading.I have tested this solution in openshift/operator-framework-operator-controller#515, and it works.
Reviewer Checklist