-
Notifications
You must be signed in to change notification settings - Fork 64
🌱 Bundle renderer refactor webhook service related function and attribute naming #1999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bundle renderer refactor webhook service related function and attribute naming #1999
Conversation
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
…viceResourceGenerator Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
=======================================
Coverage 69.11% 69.11%
=======================================
Files 79 79
Lines 7023 7023
=======================================
Hits 4854 4854
Misses 1887 1887
Partials 282 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CertName: "cert", | ||
Namespace: "namespace", | ||
CertProvider: nil, | ||
ServiceName: "webhook", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Make sense we could use it for metrics:
See for example:
Which will patch: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/config/default/cert_metrics_manager_patch.yaml
To pass the cert for the metrics server like:
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ac14a4e
into
operator-framework:main
Description
Minor refactor renaming the WebhookServiceGenerator and WebhookService attribute in the cert provider configuration. The naming is not accurate in the sense that the service is not necessarily exclusive to webhooks. In some future, if we want to implement, e.g. APIService support, the same service will be used. These are rather services that are backed by the deployments in described in the CSV.
Reviewer Checklist