✨ Add Proxy support to rukpak generator #1998
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1998 +/- ##
==========================================
+ Coverage 69.11% 69.14% +0.02%
==========================================
Files 79 79
Lines 7023 7062 +39
==========================================
+ Hits 4854 4883 +29
- Misses 1887 1896 +9
- Partials 282 283 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -56,11 +56,16 @@ func (r ResourceGenerators) ResourceGenerator() ResourceGenerator { | |||
|
|
|||
| type UniqueNameGenerator func(string, interface{}) (string, error) | |||
|
|
|||
| type Proxy struct { | |||
There was a problem hiding this comment.
nit: should we call it ProxyConfig or something?
| } | ||
| } | ||
|
|
||
| func addProxyEnvVars(httpProxy, httpsProxy, noProxy string, containers []corev1.Container) { |
There was a problem hiding this comment.
should we nuke any preexisting proxy env vars?
Description
Reviewer Checklist