-
Notifications
You must be signed in to change notification settings - Fork 64
🐛 Fix webhook service rotation to renew within 24h of expiry #1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix webhook service rotation to renew within 24h of expiry #1997
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1997 +/- ##
=======================================
Coverage 69.11% 69.11%
=======================================
Files 79 79
Lines 7023 7027 +4
=======================================
+ Hits 4854 4857 +3
- Misses 1887 1888 +1
Partials 282 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
internal/operator-controller/rukpak/render/certproviders/certmanager.go
Outdated
Show resolved
Hide resolved
internal/operator-controller/rukpak/render/certproviders/certmanager_test.go
Show resolved
Hide resolved
cf52a50
to
0cfbe80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🎉
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
52b1265
into
operator-framework:main
Description
Currently, the generated webhook certificate is set to rotate 1 year before expiry. In this PR we set it to 24h to keep parity with OLMv0 behavior.
Reviewer Checklist