Skip to content

fix: startup resource cache access #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jul 22, 2025

Addressing the issues that after startup accessing resources through context.getSecondaryResources(...) not all the initial resources are returned. Moving the index to informer solved this problem for base level API.
For dependent resource where we explicitly cache the create / updated resource we have to maintain a tempral cache until the resource is visible for the informer.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2025
@csviri csviri changed the title sec to primary as index fix: startup resource cache access Jul 22, 2025
@csviri csviri requested review from metacosm and xstefank July 22, 2025 12:52
Copy link
Collaborator

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the todo please but otherwise LGTM

csviri added 15 commits July 24, 2025 13:50
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri force-pushed the sec-to-primary-as-index branch from 0fd7580 to 17d40cc Compare July 24, 2025 11:50
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri requested a review from shawkins July 24, 2025 12:16
@csviri csviri marked this pull request as ready for review July 24, 2025 12:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2025
@openshift-ci openshift-ci bot requested a review from xstefank July 24, 2025 12:19
csviri added 2 commits July 24, 2025 14:51
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
This reverts commit faf9bdf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

context.getSecondaryResources() returns incomplete list on initial reconcile after operator startup
2 participants