Skip to content

Conversation

@astra1
Copy link

@astra1 astra1 commented Nov 1, 2025

This change truncates long item names in the navigation menu.
@systemcrash

lucibefore luciafter
  • This PR is not from my main or master branch πŸ’©, but a separate branch βœ…
  • Each commit has a valid βœ’οΈ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid πŸ“ <package name>: title first line subject for packages
  • Tested on: (x86, openwrt 24.10, firefox) βœ…
  • ( Preferred ) Screenshot or mp4 of changes:
  • Description: (describe the changes proposed in this PR)

Signed-off-by: Maxim <astralfestival@gmail.com>
@hnyman
Copy link
Contributor

hnyman commented Nov 3, 2025

This fix might be sensible, but it also shows the underlying problem: the overly long menu item itself.
The menu item should be shortened. Where is that actually coming from? Not from a normal OpenWrt package, I think.

"Information about 3G/4G/5G connection"
-->
"3G/4G/5G connection status"
"3G/4G/5G connection info"

@astra1
Copy link
Author

astra1 commented Nov 3, 2025

This fix might be sensible, but it also shows the underlying problem: the overly long menu item itself. The menu item should be shortened. Where is that actually coming from? Not from a normal OpenWrt package, I think.

"Information about 3G/4G/5G connection" --> "3G/4G/5G connection status" "3G/4G/5G connection info"

Yes, from the
luci-app-modemdata package, and it is possible to request the maintainer (@4IceG) to shorten the menu item name, but this will also be helpful for internationalization, as the translation may be even longer than the English name.

@4IceG
Copy link

4IceG commented Nov 3, 2025

No problem, in new version of the package there will be "Modemdata info" in menu, I think it will be the shortest version.

@systemcrash
Copy link
Contributor

I dislike imposing hard limits on layout space - the layout is meant to be flexible to accommodate what goes there. The side bar in that theme is hideable in any case. But addressing the actual title is an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants