[Fix] Merging with wrong format now raises Validation error #351 #355
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An attempt to merge config with wrong format will now raise a validation error instead of failing. Fixes openwisp#351
nemesifier
requested changes
Jun 12, 2025
It only prevents the original AttributeError crash and correctly lets the .validate() method handle all validation of the final merged configuration. Fixes openwisp#351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to merge config with wrong format will now raise a validation error instead of failing.
Fixes #351
Checklist
Reference to Existing Issue
Closes #351
Description of Changes
Added conditionals to check if two template types can be merged and if not raise validation error instead of failing.