Skip to content

fix(didcomm): filter out undefined modules #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

fix(didcomm): filter out undefined modules #2465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 26 additions & 24 deletions packages/didcomm/src/DidCommModule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,36 +83,38 @@ type DidCommModules<Options extends DidCommModuleConfigOptions> = {
ModuleOrEmpty<Options['basicMessages'], { basicMessages: DidCommBasicMessagesModule }>

function getDidcommModules<Options extends DidCommModuleConfigOptions>(options: Options): DidCommModules<Options> {
return {
connections: new DidCommConnectionsModule(options.connections),
oob: new DidCommOutOfBandModule(),
discovery: new DidCommDiscoverFeaturesModule(options.discovery),
return Object.fromEntries(
Object.entries({
connections: new DidCommConnectionsModule(options.connections),
oob: new DidCommOutOfBandModule(),
discovery: new DidCommDiscoverFeaturesModule(options.discovery),

credentials:
options.credentials !== false
? new DidCommCredentialsModule(options.credentials === true ? {} : options.credentials)
: undefined,
credentials:
options.credentials !== false
? new DidCommCredentialsModule(options.credentials === true ? {} : options.credentials)
: undefined,

proofs:
options.proofs !== false ? new DidCommProofsModule(options.proofs === true ? {} : options.proofs) : undefined,
proofs:
options.proofs !== false ? new DidCommProofsModule(options.proofs === true ? {} : options.proofs) : undefined,

mediator:
options.mediator !== false
? new DidCommMediatorModule(options.mediator === true ? {} : options.mediator)
: undefined,
mediator:
options.mediator !== false
? new DidCommMediatorModule(options.mediator === true ? {} : options.mediator)
: undefined,

mediationRecipient:
options.mediationRecipient !== false
? new DidCommMediationRecipientModule(options.mediationRecipient === true ? {} : options.mediationRecipient)
: undefined,
mediationRecipient:
options.mediationRecipient !== false
? new DidCommMediationRecipientModule(options.mediationRecipient === true ? {} : options.mediationRecipient)
: undefined,

messagePickup:
options.messagePickup !== false
? new DidCommMessagePickupModule(options.messagePickup === true ? {} : options.messagePickup)
: undefined,
messagePickup:
options.messagePickup !== false
? new DidCommMessagePickupModule(options.messagePickup === true ? {} : options.messagePickup)
: undefined,

basicMessages: options.basicMessages !== false ? new DidCommBasicMessagesModule() : undefined,
} as unknown as DidCommModules<Options>
basicMessages: options.basicMessages !== false ? new DidCommBasicMessagesModule() : undefined,
}).filter(([, moduleValue]) => moduleValue !== undefined)
) as unknown as DidCommModules<Options>
}

export class DidCommModule<Options extends DidCommModuleConfigOptions = DidCommModuleConfigOptions> implements Module {
Expand Down