Skip to content

Conversation

Sshovon
Copy link
Contributor

@Sshovon Sshovon commented Oct 16, 2025

The authorizationRequestExpiresInSeconds getter was returning the default value (300) even when authorizationRequestExpirationInSeconds was passed in the verifier config during agent initialization.

The config object inside the OpenId4VpVerifierService class contains another OpenId4VcVerifierModuleConfig instance instead of the raw option attributes, causing the getter in OpenId4VcVerifierModuleConfig to always fall back to its default.

This PR fixes the issue by ensuring the getter resolves the correct configuration value for authorization session expiry. I'm not entirely sure whether this nested config behavior is intentional or a construction issue.

OpenId4VcVerifierModuleConfig {
  options: OpenId4VcVerifierModuleConfig {
    options: {
      baseUrl: 'https://ad3d603bfbeb.ngrok-free.app/oid4vp',
      router: [Function],
      authorizationRequestExpirationInSeconds: 3600
    },
    router: [Function: router] {
      caseSensitive: undefined,
      mergeParams: undefined,
      params: [Object],
      strict: undefined,
      stack: [Array]
    }
  },
  router: [Function: router] {
    caseSensitive: undefined,
    mergeParams: undefined,
    params: { verifierId: [Array] },
    strict: undefined,
    stack: [ [Layer], [Layer], [Layer], [Layer], [Layer] ]
  }
}

Signed-off-by: Fairuz Rahaman Chowdhury <frcshovon@gmail.com>
@Sshovon Sshovon requested a review from a team as a code owner October 16, 2025 11:34
Copy link

changeset-bot bot commented Oct 16, 2025

⚠️ No Changeset found

Latest commit: 28b22de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TimoGlastra
Copy link
Contributor

Hm the nested conflict behavior seems like an error. Could you also fix that in this PR?

@TimoGlastra
Copy link
Contributor

I think the issue should be resolved by #2464

@Sshovon
Copy link
Contributor Author

Sshovon commented Oct 18, 2025

Great.. Closing the PR.

@Sshovon Sshovon closed this Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants