-
Notifications
You must be signed in to change notification settings - Fork 238
feat: support openid4vp v1 #2335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support openid4vp v1 #2335
Conversation
Signed-off-by: Timo Glastra <timo@animo.id>
…id4vp holder and verifier Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
🦋 Changeset detectedLatest commit: 348e2fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
…resentations with DCQL. This is only supported when the query allows 'multiple'. Due to this the API has now changed from a single presentation per query id, to an array of credential ids with at least one entry. Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions (because I'm not yet very knowledgeable about this codebase), some nits and some assertion concerns.
packages/openid4vc/src/openid4vc-holder/OpenId4vpHolderServiceOptions.ts
Show resolved
Hide resolved
packages/openid4vc/src/openid4vc-verifier/OpenId4VpVerifierService.ts
Outdated
Show resolved
Hide resolved
packages/openid4vc/src/openid4vc-verifier/OpenId4VpVerifierService.ts
Outdated
Show resolved
Hide resolved
packages/openid4vc/src/openid4vc-verifier/OpenId4VpVerifierService.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Timo Glastra <timo@animo.id>
|
@hacdias i addressed your feedback |
Signed-off-by: Timo Glastra <timo@animo.id>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimoGlastra there are still some failing tests related to the updates in the DCQL library, and also to the V1 updates. As for the rest, looks good.
Here's a patch for the tests:
From e5f024ec6ac85c2d1e83bc7c162ca1fd1b275662 Mon Sep 17 00:00:00 2001
From: Henrique Dias <mail@hacdias.com>
Date: Mon, 4 Aug 2025 10:18:28 +0200
Subject: [PATCH] fix: openid4vp-v1 tests
---
packages/openid4vc/tests/openid4vp-v1.e2e.test.ts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/packages/openid4vc/tests/openid4vp-v1.e2e.test.ts b/packages/openid4vc/tests/openid4vp-v1.e2e.test.ts
index 717d2acb6..cbb7af030 100644
--- a/packages/openid4vc/tests/openid4vp-v1.e2e.test.ts
+++ b/packages/openid4vc/tests/openid4vp-v1.e2e.test.ts
@@ -359,7 +359,7 @@ pUGCFdfNLQIgHGSa5u5ZqUtCrnMiaEageO71rjzBlov0YUH4+6ELioY=
version: 'v1',
})
).rejects.toThrow(
- 'Dcql is used as query language and verifier info (attestations) were provided, but the dcql query used credential ids that are not supported by the verifier info'
+ 'Verifier info (attestations) were provided, but the verifier info used credential ids that are not present in the query'
)
})
@@ -2436,7 +2436,7 @@ pUGCFdfNLQIgHGSa5u5ZqUtCrnMiaEageO71rjzBlov0YUH4+6ELioY=
'eu.europa.ec.eudi.pid.1': {
name: 'John Doe',
degree: 'bachelor',
- date: new DateOnly('2025-07-25'),
+ date: date,
},
},
},
--
2.50.1Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id> Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Updates openid4vp to support OpenID4VP 1.0
Also adds support for redirect_uri (unsigned client id prefix)