Skip to content

Conversation

TimoGlastra
Copy link
Contributor

@TimoGlastra TimoGlastra commented Jul 17, 2025

Updates openid4vp to support OpenID4VP 1.0

Also adds support for redirect_uri (unsigned client id prefix)

Signed-off-by: Timo Glastra <timo@animo.id>
…id4vp holder and verifier

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Copy link

changeset-bot bot commented Jul 17, 2025

🦋 Changeset detected

Latest commit: 348e2fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@credo-ts/openid4vc Minor
@credo-ts/core Minor
@credo-ts/action-menu Minor
@credo-ts/anoncreds Minor
@credo-ts/askar Minor
@credo-ts/cheqd Minor
@credo-ts/didcomm Minor
@credo-ts/drpc Minor
@credo-ts/indy-sdk-to-askar-migration Minor
@credo-ts/indy-vdr Minor
@credo-ts/node Minor
@credo-ts/question-answer Minor
@credo-ts/react-native Minor
@credo-ts/redis-cache Minor
@credo-ts/tenants Minor
@credo-ts/webvh Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
…resentations with DCQL. This is only supported when the query allows 'multiple'. Due to this the API has now changed from a single presentation per query id, to an array of credential ids with at least one entry.

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra marked this pull request as ready for review July 25, 2025 12:34
@TimoGlastra TimoGlastra requested a review from a team as a code owner July 25, 2025 12:34
Signed-off-by: Timo Glastra <timo@animo.id>
Copy link
Contributor

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions (because I'm not yet very knowledgeable about this codebase), some nits and some assertion concerns.

@TimoGlastra
Copy link
Contributor Author

@hacdias i addressed your feedback

Signed-off-by: Timo Glastra <timo@animo.id>
Copy link
Contributor

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimoGlastra there are still some failing tests related to the updates in the DCQL library, and also to the V1 updates. As for the rest, looks good.

Here's a patch for the tests:

From e5f024ec6ac85c2d1e83bc7c162ca1fd1b275662 Mon Sep 17 00:00:00 2001
From: Henrique Dias <mail@hacdias.com>
Date: Mon, 4 Aug 2025 10:18:28 +0200
Subject: [PATCH] fix: openid4vp-v1 tests

---
 packages/openid4vc/tests/openid4vp-v1.e2e.test.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/openid4vc/tests/openid4vp-v1.e2e.test.ts b/packages/openid4vc/tests/openid4vp-v1.e2e.test.ts
index 717d2acb6..cbb7af030 100644
--- a/packages/openid4vc/tests/openid4vp-v1.e2e.test.ts
+++ b/packages/openid4vc/tests/openid4vp-v1.e2e.test.ts
@@ -359,7 +359,7 @@ pUGCFdfNLQIgHGSa5u5ZqUtCrnMiaEageO71rjzBlov0YUH4+6ELioY=
         version: 'v1',
       })
     ).rejects.toThrow(
-      'Dcql is used as query language and verifier info (attestations) were provided, but the dcql query used credential ids that are not supported by the verifier info'
+      'Verifier info (attestations) were provided, but the verifier info used credential ids that are not present in the query'
     )
   })
 
@@ -2436,7 +2436,7 @@ pUGCFdfNLQIgHGSa5u5ZqUtCrnMiaEageO71rjzBlov0YUH4+6ELioY=
                         'eu.europa.ec.eudi.pid.1': {
                           name: 'John Doe',
                           degree: 'bachelor',
-                          date: new DateOnly('2025-07-25'),
+                          date: date,
                         },
                       },
                     },
-- 
2.50.1

@TimoGlastra TimoGlastra merged commit 1f74337 into openwallet-foundation:main Aug 11, 2025
17 checks passed
genaris pushed a commit to genaris/credo-ts that referenced this pull request Oct 9, 2025
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants