chore: remove verify auth callback #2310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
berendsliedrecht
commented
Jun 2, 2025
berendsliedrecht
commented
- chore: revert verifyAuthorizationRequestCallback
- docs(changeset): Revert the verifyAuthorizationCallback. Should be called outside of the framework
Signed-off-by: Berend Sliedrecht <berend@animo.id>
…lled outside of the framework Signed-off-by: Berend Sliedrecht <berend@animo.id>
🦋 Changeset detectedLatest commit: 5f1b213 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
berendsliedrecht
changed the title
TimoGlastra
reviewed
Jun 2, 2025
| "@credo-ts/openid4vc": patch | ||
| --- | ||
|
|
||
| Revert the verifyAuthorizationCallback. Should be called outside of the framework |
There was a problem hiding this comment.
i think we can just remove the previous changeset that was added (and this one), so we don't clutter the changelog
TimoGlastra
reviewed
Jun 2, 2025
| ) | ||
|
|
||
| await verifierTenant1.endSession() | ||
| await verifierTenant2.endSession() |
There was a problem hiding this comment.
this test was added for this purpose right, so we cna probably remove it? Or did you adapt an existing test?
There was a problem hiding this comment.
Adapted existing.
TimoGlastra
approved these changes
Jun 2, 2025
berendsliedrecht
merged commit 589a16e
into
openwallet-foundation:main
34 of 35 checks passed
berendsliedrecht
added a commit
to animo/credo-ts
that referenced
this pull request
Jun 4, 2025
* chore: revert verifyAuthorizationRequestCallback Signed-off-by: Berend Sliedrecht <berend@animo.id> * docs(changeset): Revert the verifyAuthorizationCallback. Should be called outside of the framework Signed-off-by: Berend Sliedrecht <berend@animo.id> --------- Signed-off-by: Berend Sliedrecht <berend@animo.id>
genaris
pushed a commit
to genaris/credo-ts
that referenced
this pull request
Oct 9, 2025
* chore: revert verifyAuthorizationRequestCallback Signed-off-by: Berend Sliedrecht <berend@animo.id> * docs(changeset): Revert the verifyAuthorizationCallback. Should be called outside of the framework Signed-off-by: Berend Sliedrecht <berend@animo.id> --------- Signed-off-by: Berend Sliedrecht <berend@animo.id> Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.