fix(cheqd): Only sign cheqd DID updates with authentication VMs #2305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
🦋 Changeset detectedLatest commit: 0dc9b00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
is there anyway i can trigger the tests? |
DaevMithran
reviewed
May 29, 2025
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
DaevMithran
approved these changes
May 29, 2025
@gmulhearn I made a change in #2306 to fix the CI |
|
Updated the branch, it should now run CI again |
|
There's some linting errors @gmulhearn, can you fix these? |
|
Also, could you add a changeset @gmulhearn ? |
…ly authentication verification methods rather than all verification methods Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
…n/credo-ts into gm/cheqd-auth-only-sigs
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
gmulhearn
changed the title
|
@TimoGlastra should be resolved 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports fixes from upstream https://github.com/openwallet-foundation/credo-ts/blob/main/packages/cheqd/src/dids/CheqdDidRegistrar.ts