feat(didcomm): Queue Transport repository #2292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TransportRepository, and now belongs to DidCommModule configuration. As a result, MessagePickupRepository injection symbol has been dropped. If you want to retrieve current QueueTransportRepository instance, resolve DidCommModuleConfig and get `queueTransportRepository`. All methods in QueueTransportRepository now include `AgentContext` as their first argument. Please enter a summary for your changes. Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
🦋 Changeset detectedLatest commit: bfa624c The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9 tasks
genaris
changed the title
TimoGlastra
approved these changes
May 23, 2025
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
This was referenced May 26, 2025
genaris
added a commit
to genaris/credo-ts
that referenced
this pull request
Oct 9, 2025
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up from #2168 where we found that it would be a good idea to move "Message Pickup Repository" to DIDComm main module, calling it "Queue Transport Repository" (to be consistent with naming used in DIDComm spec.
Good thing about this is that now we could get rid of
InjectionSymbols.MessagePickupRepository.Here we also add AgentContext to all methods of the newly defined QueueTransportRepository interface.