Skip to content

fix: correct revocation registry check edge case #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

fix: correct revocation registry check edge case #2282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44e6516
fix: correct revocation registry check edge case
bryce-mcmath May 13, 2025
0559dfb
Create violet-meals-worry.md
TimoGlastra May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/violet-meals-worry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@credo-ts/indy-vdr": patch
---

fix: correct revocation registry check edge case
2 changes: 1 addition & 1 deletion packages/indy-vdr/src/anoncreds/utils/transform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function anonCredsRevocationStatusListFromIndyVdr(
// Check whether the highest delta index is supported in the `maxCredNum` field of the
// revocation registry definition. This will likely also be checked on other levels as well
// by the ledger or the indy-vdr library itself
if (Math.max(...delta.issued, ...delta.revoked) >= revocationRegistryDefinition.value.maxCredNum) {
if (Math.max(...delta.issued, ...delta.revoked) > revocationRegistryDefinition.value.maxCredNum) {
throw new CredoError(
`Highest delta index '${Math.max(
...delta.issued,
Expand Down
Loading