-
Notifications
You must be signed in to change notification settings - Fork 220
fix(cheqd): Populate contexts for JsonLD issuance #2250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v0.5.x
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ae6ba78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: DaevMithran <daevmithran1999@gmail.com>
Hey @TimoGlastra @berendsliedrecht appreciate you're probably slammed busy with EIC and other work, but it would be great if you could find a few mins to take a look at this one |
So it seems that the document that is passed to the frame method only contains the following context: "@context": [
"https://w3id.org/did/v1",
"https://w3id.org/security/suites/jws-2020/v1"
], And thus it's missing the required On uniresolver (https://dev.uniresolver.io/) it does return the correct ed25519 context. It seems that we directly use the document received from the SDK, as I can't find where we set the @context on the document when we resolve a cheqd did |
Thanks @TimoGlastra we're now working on a fix in our SDK to align the |
Signed-off-by: Sownak Roy <sownak@cheqd.io>
Signed-off-by: DaevMithran <daevmithran1999@gmail.com>
@TimoGlastra the resolveDid in cheqd populates the context as expected. But we noticed the contexts were missing in the didRecord saved within the wallet. For issuance shouldn't the flow resolve the DID instead of relying on the didRecord locally for the DIDDocument |
@DaevMithran for now we assume all updates are made through credo and thus the local record should match. It's very inefficient to resolve the did every time you want to issue. We could do a periodic fetch, but I'd rather rely on the local record. I think we should fix the inconsistency between the cheqd ledger record and the local did record |
Signed-off-by: DaevMithran <daevmithran1999@gmail.com>
Signed-off-by: Sownak Roy <sownak@cheqd.io>
Signed-off-by: Sownak Roy <sownak@cheqd.io>
Signed-off-by: Sownak Roy <20537268+sownak@users.noreply.github.com>
…wallet Signed-off-by: DaevMithran <daevmithran1999@gmail.com>
Signed-off-by: Sownak Roy <sownak@cheqd.io>
…in context Signed-off-by: Sownak Roy <sownak@cheqd.io>
we are facing an issue in JSONLD issuance with credo, and issue is with the default document loader
This is the input for jsond.frame in default document loader
The result is missing the publicKeyBase58, same is the case for other signature suites.