Skip to content

fix: skip signature validation of the trusted certificate #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2025
Merged

fix: skip signature validation of the trusted certificate #2248

merged 4 commits into from
Apr 11, 2025

Conversation

TimoGlastra
Copy link
Contributor

@TimoGlastra TimoGlastra commented Apr 4, 2025 •
edited
Loading

If the certificate is trusted we skip the signature verification as we don't know the public key of the signer. But we already trust the certificate.
Also adds a test based on Google CM Wallet

@TimoGlastra
test: add test for mdoc device response from google cm wallet
b5b4ce7 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra requested a review from a team as a code owner April 4, 2025 15:53
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 01a30e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TimoGlastra
test: add now
b23991e 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
fix: do not verify trusted certificate without public key
717e307 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra changed the title test: add test for mdoc device response from google cm wallet fix: skip signature validation of the trusted certificate Apr 4, 2025
@TimoGlastra TimoGlastra enabled auto-merge (squash) April 11, 2025 08:43
@berendsliedrecht
Copy link
Contributor

If the certificate is trusted we skip the signature verification as we don't know the public key of the signer. But we already trust the certificate.

Also adds a test based on Google CM Wallet

If it is a root cert, we can validate the signature. Should we not do that?

@TimoGlastra TimoGlastra merged commit 3aab0ee into openwallet-foundation:main Apr 11, 2025
20 checks passed
GHkrishna pushed a commit to GHkrishna/credo-ts that referenced this pull request Apr 17, 2025
@TimoGlastra @GHkrishna
fix: skip signature validation of the trusted certificate (openwallet…
0ea93dc 
…-foundation#2248)

Signed-off-by: Timo Glastra <timo@animo.id>
genaris pushed a commit to genaris/credo-ts that referenced this pull request Oct 9, 2025
@TimoGlastra @genaris
fix: skip signature validation of the trusted certificate (openwallet…
1544661 
…-foundation#2248)

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berendsliedrecht berendsliedrecht berendsliedrecht approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimoGlastra @berendsliedrecht