fix: presenting proof for non Mdoc VCs

[MosCD3]

This fixes #2222

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8591203

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[TimoGlastra]

Is this issue also present in the latest 0.6 alpha? Since this PR won't affect 0.5.x releases

[MosCD3]

I assume it is, since the same cause is in the main branch

[MosCD3]

We ended up patching 0.5.13 to get Bifold to work with SD-JWT and JWTs

[MosCD3]

@TimoGlastra Any thing needs to be done for this fix to go in?

[TimoGlastra]

I'm not really sure what is causing this error.

The pex library should return an array. And the version being used in for pex 0.6 is different than 0.5

So:

• does this error only occur on 0.5 or also 0.6? If only on 0.5 it should not go into the 0.6 branch
• can you provide a reproducible example where no array is returned? I would like to add a test.

So before merging i'd like to understand the root cause, as the pex library should return an array in all cases

[MosCD3]

@TimoGlastra Couple of things here
1st, this is not about PEX, there is an issue with logic itself
Observe when its MDOC, the object is structured this way

 verifiablePresentationResultsWithFormat.push({
          verifiablePresentationResult: {
            presentationSubmission: presentationSubmission,
            verifiablePresentations: [deviceResponseBase64Url],
            presentationSubmissionLocation,
          },
          claimFormat: presentationToCreate.claimFormat,
        })

When its not, the object is structured this way

   verifiablePresentationResultsWithFormat.push({
          verifiablePresentationResult,
          claimFormat: presentationToCreate.claimFormat,
        })

So, if PEX library returns and array regardless, this function has to be refactored to always construct the object verifiablePresentationResultsWithFormat consistent regardless

About testing, I can't see any docs or sample implementation for credo-6 to try with. Please guide me if you have more info