Skip to content

feat: add fastify support #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

feat: add fastify support #2212

wants to merge 23 commits into from

Conversation

sloops77
Copy link

@sloops77 sloops77 commented Mar 5, 2025 •
edited
Loading

Second Attempt at implementing #2147
Replaces #2150

TODO

Must Have

  • Add HTTP response headers handling
  • Add back default router if none specified
  • Convert rest of configure methods
  • Tests for fastify

Nice to have

  • Add all HTTP methods to CredoRouter
  • Add example errors to tests (express & fastify)
  • Specify correct Generic types for all routes
  • Permit org to utilize different versions of the spec via configuration only

Future work suggestions

  • Could RequestContext loggers be supported instead of dependency injected/Agent Config
  • Use Zod schemas in fastify endpoint specifications
  • Rationalize error throwing and standardize the properties on errors

@sloops77 sloops77 requested a review from a team as a code owner March 5, 2025 02:29
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 57c981f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@credo-ts/openid4vc Minor
@credo-ts/action-menu Minor
@credo-ts/anoncreds Minor
@credo-ts/askar Minor
@credo-ts/cheqd Minor
@credo-ts/core Minor
@credo-ts/didcomm Minor
@credo-ts/drpc Minor
@credo-ts/indy-sdk-to-askar-migration Minor
@credo-ts/indy-vdr Minor
@credo-ts/node Minor
@credo-ts/question-answer Minor
@credo-ts/react-native Minor
@credo-ts/tenants Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sloops77 sloops77 marked this pull request as draft March 5, 2025 02:33
@sloops77 sloops77 force-pushed the refactor/2147-add-fastify-support branch from 1e3c8b9 to 7d69189 Compare March 5, 2025 02:52
@sloops77 sloops77 changed the title Refactor/2147 add fastify support feat: add fastify support Mar 5, 2025
@sloops77 sloops77 force-pushed the refactor/2147-add-fastify-support branch from 8a868cd to 74bfb77 Compare March 5, 2025 06:51
sloops77 added 6 commits March 6, 2025 06:37
docs(changeset): Add support for fastify
057ed7b 
Signed-off-by: sloops77 <andres.olave@thinkingbytes.net>
refactor: add fastify support
4396309 
Signed-off-by: sloops77 <andres.olave@thinkingbytes.net>
refactor: remove @openid4vc/utils
d584fd2 
Signed-off-by: sloops77 <andres.olave@thinkingbytes.net>
refactor: migrate OpenId4VcIssuerModuleConfig to BaseOpenId4VcIssuerM…
f1c011a 
…oduleConfig

Signed-off-by: sloops77 <andres.olave@thinkingbytes.net>
fix: migrate OpenId4VcIssuerModuleConfig to BaseOpenId4VcIssuerModule…
3b3bf3e 
…Config

Signed-off-by: sloops77 <andres.olave@thinkingbytes.net>
fix: migrate OpenId4VcIssuerModuleConfig to BaseOpenId4VcIssuerModule…
c897c45 
…Config

Signed-off-by: sloops77 <andres.olave@thinkingbytes.net>
@sloops77 sloops77 force-pushed the refactor/2147-add-fastify-support branch from fd49190 to c897c45 Compare March 5, 2025 19:38
@sloops77
Copy link
Author

sloops77 commented Mar 7, 2025

@TimoGlastra pls review

sloops77 and others added 13 commits March 8, 2025 09:21
fix: registration of moduleconfig
848de68 
refactor: extract Credo adapters to Http framworks
refactor: share issuer modules logic for fastify & express

Signed-off-by: sloops77 <andres.olave@thinkingbytes.net>
feat: added back automatic router creation if none passed in config o…
264d70f 
…ptions

Signed-off-by: sloops77 <andres.olave@thinkingbytes.net>
refactor: add SupportRouterType to context.ts
3c99a4b 
Signed-off-by: sloops77 <andres.olave@thinkingbytes.net>
@sloops77
Merge remote-tracking branch 'origin/main' into refactor/2147-add-fas…
b9cb6e1 
…tify-support
@sloops77
fix: fix tests
6b4e947 
Signed-off-by: Andres Olave <arolave@gmail.com>
@sloops77
Merge branch 'main' of https://github.com/openwallet-foundation/credo-ts
dde59ed 
 into refactor/2147-add-fastify-support
@sloops77
fix: dependency injection
ac61efa 
Signed-off-by: Andres Olave <arolave@gmail.com>
@sloops77
chore: upgrade fastify
4a9bbf1 
Signed-off-by: Andres Olave <arolave@gmail.com>
@sloops77
fix: OpenId4VcIssuerModuleConfig dependency injection
dc58997 
Signed-off-by: Andres Olave <arolave@gmail.com>
@sloops77
chore: change fastify import to type
7016abb 
Signed-off-by: Andres Olave <arolave@gmail.com>
@sloops77
fix: dont use express error handler if res.headerSent==true
bc00ac4 
Signed-off-by: Andres Olave <arolave@gmail.com>
@sloops77
style: create generic error creation functions
5838421 
Signed-off-by: Andres Olave <arolave@gmail.com>
@sloops77
fix: broken presentationduringissuance tests
424cb4e 
Signed-off-by: Andres Olave <arolave@gmail.com>
@sloops77
Copy link
Author

sloops77 commented May 2, 2025

@TimoGlastra Reminder to please give us feedback when you can

@nassan
test: commands added for different module injections
299a4c4 
Signed-off-by: nassan <nassanpaul@gmail.com>
@nassan nassan force-pushed the refactor/2147-add-fastify-support branch from 9dffec6 to 299a4c4 Compare May 15, 2025 12:33
@nassan
Copy link
Contributor

nassan commented May 15, 2025

@sloops77 wdyt of 299a4c4 for injection of different modules?

@nassan
feat: issuerMetadataEndpoint fastify support
10931bc 
Signed-off-by: nassan <nassanpaul@gmail.com>
@sloops77
Copy link
Author

sloops77 commented May 16, 2025 •
edited
Loading

@sloops77 wdyt of 299a4c4 for injection of different modules?

@nassan you'll want to use https://jestjs.io/docs/api#describeeachtablename-fn-timeout with one table entry using express module for issuer and holder and the other fastify

@sloops77
Copy link
Author

sloops77 commented May 19, 2025 •
edited
Loading

@TimoGlastra
Our thinking has evolved to using https://github.com/openwallet-foundation-labs/oid4vc-ts directly. That means we will pause working on this PR. But will be giving that library and it's sister repositories a good workout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sloops77 @nassan