-
Notifications
You must be signed in to change notification settings - Fork 37
Contribute Cache Redis Plugin #2311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Contribute Cache Redis Plugin #2311
Conversation
Signed-off-by: Char Howland <char@indicio.tech>
0bc3765 to
2e98494
Compare
Signed-off-by: Char Howland <char@indicio.tech>
6c3b5f3 to
390a7f4
Compare
Signed-off-by: Char Howland <char@indicio.tech>
d0efb8e to
dc393e2
Compare
|
Recommendation to merge the following PR once this one has been merged: Indicio-tech/aries-acapy-cache-redis#46 |
jamshale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution. I don't see any problem with going ahead and getting this merged once the integration tests are passing.
| yield _create_schema | ||
|
|
||
|
|
||
| # @pytest.fixture(autouse=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this commented code useful for future reference?
| yield _create_schema | ||
|
|
||
|
|
||
| # @pytest.fixture(autouse=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here.
This PR contributes Indicio's ACA-Py Cache Redis plugin to the OWF ACA-Py plugins repo. Credit to @TheTechmage, @anwalker293, @dbluhm , @burdettadam, and @shaangill025 for development.