Skip to content

Show critical error with more details #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

RHeckerIntel
Copy link
Collaborator

Allow the user to see more details. Might help debugging in the future?

Screenshot 2025-02-19 135840

Also removed image inference setup font since that is not required

Also removed image inference setup font since that is not required
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 524 files.

Valid Invalid Ignored Fixed
251 1 272 0
Click to see the invalid file list
  • lib/widgets/dialogs/critical_error.dart
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

@@ -0,0 +1,43 @@
import 'package:fluent_ui/fluent_ui.dart';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import 'package:fluent_ui/fluent_ui.dart';
// Copyright (c) 2024 Intel Corporation
//
// SPDX-License-Identifier: Apache-2.0
import 'package:fluent_ui/fluent_ui.dart';

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 19.12%. Comparing base (c0a7011) to head (fc1b502).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
lib/widgets/dialogs/critical_error.dart 0.00% 15 Missing ⚠️
lib/utils.dart 0.00% 5 Missing ⚠️
lib/openvino_console_app.dart 0.00% 2 Missing ⚠️
lib/pages/download_model/download_model.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #103       +/-   ##
===========================================
- Coverage   37.92%   19.12%   -18.81%     
===========================================
  Files          74      139       +65     
  Lines        2853     5753     +2900     
===========================================
+ Hits         1082     1100       +18     
- Misses       1771     4653     +2882     
Flag Coverage Δ
unittests 19.12% <0.00%> (-18.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RHeckerIntel RHeckerIntel merged commit b27b4e5 into main Feb 24, 2025
11 of 14 checks passed
@RHeckerIntel RHeckerIntel deleted the rhecker/error-reporting-dialogs branch February 24, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant