Skip to content

[Core][Ref] PagedAttention reference implementation #28815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 166 commits into
base: master
Choose a base branch
from
Open

[Core][Ref] PagedAttention reference implementation #28815

wants to merge 166 commits into from
+2,045 −342

Conversation

@PiotrKrzem
Copy link
Contributor

@PiotrKrzem PiotrKrzem commented Feb 4, 2025 •
edited
Loading

Details:

  • Add PagedAttention reference implementation
  • Add testing suite

Tickets:

  • 158135

@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common category: TEMPLATE OpenVINO Template plugin category: CPP API OpenVINO CPP API bindings labels Feb 4, 2025
@vshampor
Copy link
Contributor

You should also be adding the cache rotation-related functionality here since it's part of the op and has both CPU and GPU implementations now.

@github-actions github-actions bot added category: CPU OpenVINO CPU plugin category: transformations OpenVINO Runtime library - Transformations category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin labels Feb 27, 2025
@github-actions github-actions bot removed category: CPU OpenVINO CPU plugin category: transformations OpenVINO Runtime library - Transformations category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin labels Feb 28, 2025
@mlukasze mlukasze requested a review from vshampor February 28, 2025 05:56
@PiotrKrzem PiotrKrzem marked this pull request as ready for review February 28, 2025 06:44
@PiotrKrzem PiotrKrzem requested review from a team as code owners February 28, 2025 06:44
@mlukasze mlukasze added this to the 2025.4 milestone Oct 21, 2025
@mlukasze mlukasze requested a review from praasz October 28, 2025 09:15
@PiotrKrzem
Copy link
Contributor Author

PiotrKrzem commented Oct 30, 2025 •
edited
Loading

NEW: Due to the namespace error, I've made a script that went over all common optimizations and checked if the file has usae of "op::" namespace but without "using namespace ov" directive at the beginning, and then changed "op::" to "ov::op::"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-jankowski t-jankowski t-jankowski approved these changes

@vshampor vshampor Awaiting requested review from vshampor

@mmikolajcz mmikolajcz Awaiting requested review from mmikolajcz

@itikhono itikhono Awaiting requested review from itikhono

@zhangYiIntel zhangYiIntel Awaiting requested review from zhangYiIntel

@mitruska mitruska Awaiting requested review from mitruska

@luo-cheng2021 luo-cheng2021 Awaiting requested review from luo-cheng2021

@praasz praasz Awaiting requested review from praasz

Requested changes must be addressed to merge this pull request.

Assignees

@luo-cheng2021 luo-cheng2021

Labels

category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common category: TEMPLATE OpenVINO Template plugin category: transformations OpenVINO Runtime library - Transformations

Projects

None yet

Milestone

2025.4

Development

Successfully merging this pull request may close these issues.