Skip to content

refactor: improve file-io errors #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2024
Merged

refactor: improve file-io errors #343

merged 4 commits into from
May 27, 2024

Conversation

ComradeVanti
Copy link
Collaborator

Refactor logic for file-system related io errors. The main changes are:

  • We now log all file-system errors when they happen using the debug logger. This way we don't need to bubble the errors all the way up to the cli layer.
  • There are now two file-system error types as part of the domain. One for when a file is missing and one for everything else.
  • The FileMissingError allows to pass a constant string which identifies the missing file ("ProjectVersion.txt", "ProjectManifest", ...). This way the error can be reused for different files but still be differentiated for better logging.

@ComradeVanti ComradeVanti merged commit 1718247 into master May 27, 2024
6 checks passed
@ComradeVanti ComradeVanti deleted the file-io-errors branch May 27, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant