refactor: upmconfig load logic #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have a service function for determining the directory in which the upmconfig is located. On load and save the actual file path of the config is constructed from this directory. There is no need for this delayed path construction. We can instead make the service resolve the actual path of the config file right away. This makes client code a little shorter.
ComradeVanti
added a commit
that referenced
this pull request
May 22, 2024
Currently we return the path of the upm config file we modified after a save so that the path can be in logging. This is done because previously we only had access to the configs directory path in the client code. Since #337 we also have access to the file path in client code and so dont need this return value.
ComradeVanti
added a commit
that referenced
this pull request
May 22, 2024
Currently we return the path of the upm config file we modified after a save so that the path can be in logging. This is done because previously we only had access to the configs directory path in the client code. Since #337 we also have access to the file path in client code and so dont need this return value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a service function for determining the directory in which the upmconfig is located. On load and save the actual file path of the config is constructed from this directory.
There is no need for this delayed path construction. We can instead make the service resolve the actual path of the config file right away. This makes client code a little shorter.