-
Notifications
You must be signed in to change notification settings - Fork 169
VIDCS-3685: Connection Service integration with FCM for notifications push #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This application provides a completed version of the OpenTok [Basic Video Chat tutorial](https://tokbox.com/developer/tutorials/android/) for Android (differing only in some additional validation checks). Upon deploying this sample application, you should be able to have two-way audio and video communication using OpenTok. | ||
|
||
Main features: | ||
* Connect to an OpenTok session | ||
* Publish an audio-video stream to the session | ||
* Subscribe to another client's audio-video stream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we improve this README? I was expecting to find an introduction about the connection services and FCM (and how the app supports it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am working on it still. Should be pushed still today
|
||
private FcmEventSender() {} | ||
|
||
// IMPORTANT: This network operation should NOT run on the main thread! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume there is one or several blocking calls, that's why you create a new thread. That said, isn't there any really asynchronous alternative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are now using ExecutorService for async calls
Does the microphone and camera capture work in background with the latest android SDKs? |
Providing sample integrating a connection service with the vonage webrtc functionalities