fix(input):fix textarea height in saas model #3608
Conversation
WalkthroughThis update refactors icon usage in the grid component, adjusts textarea height calculation logic in the input component, and tweaks button styling by modifying CSS classes. No public APIs or exports are changed; all modifications are internal and focused on component implementation details. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/design/aurora/src/grid/index.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/renderless/src/input/index.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/vue/src/button/src/token.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/design/aurora/src/grid/index.ts(2 hunks)packages/renderless/src/input/index.ts(1 hunks)packages/vue/src/button/src/token.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
packages/design/aurora/src/grid/index.ts (2)
Learnt from: Davont
PR: #2513
File: packages/vue/src/huicharts/huicharts-histogram/src/chart-histogram.vue:33-36
Timestamp: 2024-11-25T03:43:05.285Z
Learning: 在 Tiny Vue 代码库中，使用 chart-core 中的 huiChartOption 的组件，不应在其 data 中定义 huiChartOption 或 option，而是应该依赖 chart-core 提供的 huiChartOption。
Learnt from: Davont
PR: #2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue的组件中，当使用chart-core时，应删除错误的option定义，使用chart-core中的huiChartOption。
packages/renderless/src/input/index.ts (1)
Learnt from: zzcr
PR: #2481
File: packages/theme/src/time-range/vars.less:27-28
Timestamp: 2024-11-04T09:35:13.159Z
Learning: 在 packages/theme/src/time-range/vars.less 文件中，应使用 var(--tv-TimeRange-header-height) 作为 --tv-TimeRange-header-line-height 的值，以保持一致性。
🔇 Additional comments (2)
packages/vue/src/button/src/token.ts (1)
51-51: LGTM! Button styling improvement looks good.The addition of vertical padding (
py-1) and increased line height (leading-5.5) should improve the visual balance of no-circle buttons.packages/design/aurora/src/grid/index.ts (1)
1-1: LGTM! Clean icon replacement from chevrons to triangles.The update from chevron icons to triangle icons for sorting indicators is appropriate and the implementation is correct.
Also applies to: 14-15
| @@ -161,7 +161,7 @@ export const calcTextareaHeight = | |||
| minHeight = props.height | |||
| } | |||
| if (!state.isDisplayOnly) { | |||
| height = Math.max(minHeight, height) | |||
| height = Math.min(minHeight, height) | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify this fundamental change to textarea height calculation logic.
This change reverses the height calculation logic from enforcing a minimum height to enforcing a maximum height constraint. The textarea height is now capped at minHeight rather than using it as a lower bound.
This is a significant behavioral change that could affect all existing textarea implementations. Please confirm this is the intended behavior for the SaaS model fix and that it won't break existing functionality.
🏁 Script executed:
#!/bin/bash
# Search for other usages of calcTextareaHeight to understand the impact
echo "=== Searching for calcTextareaHeight usage ==="
rg -A 5 -B 2 "calcTextareaHeight"
echo -e "\n=== Searching for textarea height related issues or tests ==="
rg -A 3 -B 3 "(textarea.*height|height.*textarea)" --type ts --type js
echo -e "\n=== Looking for SaaS mode related code ==="
rg -A 3 -B 3 "(saas|SaaS)" --type ts --type jsLength of output: 77036
🏁 Script executed:
#!/bin/bash
sed -n '140,200p' packages/renderless/src/input/index.tsLength of output: 1760
Fix incorrect min-height logic in calcTextareaHeight
The current code uses height = Math.min(minHeight, height), which caps the textarea height at minHeight instead of enforcing it as a lower bound. This causes all non–display-only textareas to render at exactly minHeight, ignoring content growth.
Please update the minimum-height logic as follows:
• File: packages/renderless/src/input/index.ts
Lines ~156–161
Suggested change:
- if (!state.isDisplayOnly) {
- height = Math.min(minHeight, height)
- textareaStyle.minHeight = `${Math.floor(minHeight)}px`
- } else {
- textareaStyle.minHeight = `0px`
- }
+ if (!state.isDisplayOnly) {
+ // enforce minHeight as a floor, not a cap
+ height = Math.max(minHeight, height)
+ textareaStyle.minHeight = `${Math.floor(minHeight)}px`
+ } else {
+ textareaStyle.minHeight = `0px`
+ }This restores the intended behavior: the textarea will grow with content but never shrink below minHeight.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| height = Math.min(minHeight, height) | |
| // packages/renderless/src/input/index.ts | |
| if (!state.isDisplayOnly) { | |
| - height = Math.min(minHeight, height) | |
| + // enforce minHeight as a floor, not a cap | |
| + height = Math.max(minHeight, height) | |
| textareaStyle.minHeight = `${Math.floor(minHeight)}px` | |
| } else { | |
| textareaStyle.minHeight = `0px` | |
| } |
🤖 Prompt for AI Agents
In packages/renderless/src/input/index.ts around line 164, the code incorrectly
uses Math.min to enforce minHeight, which limits the height to at most minHeight
instead of at least minHeight. Replace Math.min with Math.max so that height is
set to the greater of minHeight and the calculated height, ensuring the textarea
grows with content but never shrinks below minHeight.
PR
fix:修复saas模式下文本域高度问题
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Style
Bug Fixes