fix: adapt to tree children use splice to add row

[gimmyhehe]

PR

兼容树表children使用splice push新增行场景

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Improved tracking of data length in tree-structured tables, ensuring accurate row counts even with nested data.

• Refactor

  • Streamlined data change handling by migrating from traditional watchers to the new composition API approach, enhancing maintainability and consistency.
  • Removed legacy Vue 3-specific data watchers to simplify the codebase.

[coderabbitai]

Walkthrough

The changes introduce a new useData composable to manage and track the expanded length of data, especially for tree structures, within the grid component. Data change detection and handling are migrated from options API watchers and lifecycle hooks to the composition API using this composable, with related legacy code and methods removed.

Changes

File(s)	Change Summary
.../grid/src/composable/useData.ts	Added new useData composable, with helpers for tree data length calculation and reactivity setup.
.../grid/src/table/src/methods.ts	Removed watchDataForVue3 method and its isVue2 import.
.../grid/src/table/src/table.ts	Removed legacy data watchers and lifecycle calls; integrated useData composable in setup.

Poem

In the garden of code where data trees grow,
A new composable helps their true length to show.
Old watchers retire, new reactivity blooms,
With useData in place, the grid now resumes.
Hopping ahead, with structure anew,
The rabbits rejoice—so should you! 🐇🌱

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/vue/src/grid/src/composable/useData.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

packages/vue/src/grid/src/table/src/methods.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

packages/vue/src/grid/src/table/src/table.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8f2fb2 and 66d36e7.

📒 Files selected for processing (3)

• packages/vue/src/grid/src/composable/useData.ts (2 hunks)
• packages/vue/src/grid/src/table/src/methods.ts (1 hunks)
• packages/vue/src/grid/src/table/src/table.ts (3 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*`: 用于写产品需求和开发文档的文件，需求应尽量写得简单清晰易懂。 在需求设计阶段应遵从逐步迭代的原则，早期版本可以尽量简洁。

**/*: 用于写产品需求和开发文档的文件，需求应尽量写得简单清晰易懂。
在需求设计阶段应遵从逐步迭代的原则，早期版本可以尽量简洁。

📄 Source: CodeRabbit Inference Engine (.cursor/rules/product.mdc)

List of files the instruction was applied to:

• packages/vue/src/grid/src/table/src/table.ts
• packages/vue/src/grid/src/table/src/methods.ts
• packages/vue/src/grid/src/composable/useData.ts

🧠 Learnings (2)

packages/vue/src/grid/src/table/src/table.ts (3)

Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-heatmap/src/chart-heatmap.vue:38-40
Timestamp: 2024-11-25T03:43:19.322Z
Learning: 在 Vue.js 组件（如 `chart-heatmap.vue`）中，使用来自 `chart-core` 的 `huiChartOption` 来管理图表选项，不要在 `data()` 中声明 `option`。

Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:33.808Z
Learning: 对于使用了来自`@opentiny/vue-huicharts-core`中`Core` mixin的组件，`huiChartOption`数据属性已由`chart-core`提供，因此无需在组件的`data()`中声明。

Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-histogram/src/chart-histogram.vue:33-36
Timestamp: 2024-11-25T03:43:05.285Z
Learning: 在 Tiny Vue 代码库中，使用 `chart-core` 中的 `huiChartOption` 的组件，不应在其 `data` 中定义 `huiChartOption` 或 `option`，而是应该依赖 `chart-core` 提供的 `huiChartOption`。

packages/vue/src/grid/src/table/src/methods.ts (2)

Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-histogram/src/chart-histogram.vue:33-36
Timestamp: 2024-11-25T03:43:05.285Z
Learning: 在 Tiny Vue 代码库中，使用 `chart-core` 中的 `huiChartOption` 的组件，不应在其 `data` 中定义 `huiChartOption` 或 `option`，而是应该依赖 `chart-core` 提供的 `huiChartOption`。

Learnt from: Davont
PR: opentiny/tiny-vue#2513
File: packages/vue/src/huicharts/huicharts-heatmap/src/chart-heatmap.vue:38-40
Timestamp: 2024-11-25T03:43:19.322Z
Learning: 在 Vue.js 组件（如 `chart-heatmap.vue`）中，使用来自 `chart-core` 的 `huiChartOption` 来管理图表选项，不要在 `data()` 中声明 `option`。

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: PR E2E Test (pnpm test:e2e3)

🔇 Additional comments (8)

packages/vue/src/grid/src/table/src/methods.ts (1)

88-88: LGTM - Clean refactor aligning with migration to Composition API.

The removal of watchDataForVue3 method and migration of data change handling to the new useData composable is a good modernization that centralizes reactive data length tracking.

packages/vue/src/grid/src/table/src/table.ts (3)

49-49: Well-integrated composable import.

The import of useData composable is properly placed with other composables.

---

731-731: Clean integration of useData composable.

The useData composable is properly invoked in the setup function and the destructured tiledLength provides reactive tracking of expanded data length including tree structures.

---

822-822: Proper exposure of reactive tiledLength.

The tiledLength is correctly returned from setup function, making it available for use in computed properties and template rendering.

packages/vue/src/grid/src/composable/useData.ts (4)

1-1: Appropriate import for Vue composition utilities.

The hooks import provides the necessary Vue 3 composition API utilities for this composable.

---

128-140: Well-implemented recursive tree length calculation.

The getTreeLength function correctly calculates the total count of all nodes in a tree structure including descendants. The recursive approach properly handles nested children.

---

142-147: Smart length calculation strategy.

The getTiledLength function appropriately chooses between tree-aware and simple array length calculation based on the presence of tree configuration.

---

149-160: Excellent solution for reactive data length tracking.

The useData composable provides a robust solution that:

• Uses reactive ref for proper Vue 3 reactivity
• Watches both raw data changes and computed tiled length
• Triggers handleDataChange appropriately
• Should properly handle splice operations on tree children by detecting length changes

This implementation addresses the PR objective of adapting to tree children splice operations by providing more reliable change detection than the previous approach.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.