fix(grid): fix scroll to bottom header not visible #3539
Conversation
WalkthroughThe Changes
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/vue/src/grid/src/table/src/utils/updateStyle.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/vue/src/grid/src/table/src/utils/updateStyle.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*`: 用于写产品需求和开发文档的文件，需求应尽量写得简单清晰易懂。 在需求设计阶段应遵从逐步迭代的原则，早期版本可以尽量简洁。
**/*: 用于写产品需求和开发文档的文件，需求应尽量写得简单清晰易懂。
在需求设计阶段应遵从逐步迭代的原则，早期版本可以尽量简洁。
📄 Source: CodeRabbit Inference Engine (.cursor/rules/product.mdc)
List of files the instruction was applied to:
packages/vue/src/grid/src/table/src/utils/updateStyle.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (1)
packages/vue/src/grid/src/table/src/utils/updateStyle.ts (1)
31-31: LGTM! Property destructuring correctly updated.The addition of
scrollYLoadto the destructuring assignment is appropriate and necessary for the conditional logic below.
| if (scrollYLoad && !_vm.bodyWrapperHeight) { | ||
| _vm.bodyWrapperHeight = maxHeight | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add null safety check for maxHeight assignment.
The conditional logic correctly addresses the scroll-to-bottom header visibility issue by ensuring bodyWrapperHeight is set when vertical scroll loading is enabled. However, there's a potential issue: maxHeight could be undefined if it wasn't initially set in _vm, which would result in assigning undefined to bodyWrapperHeight.
- if (scrollYLoad && !_vm.bodyWrapperHeight) {
- _vm.bodyWrapperHeight = maxHeight
- }
+ if (scrollYLoad && !_vm.bodyWrapperHeight && maxHeight) {
+ _vm.bodyWrapperHeight = maxHeight
+ }This ensures bodyWrapperHeight is only set when maxHeight has a valid value, preventing potential layout issues.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if (scrollYLoad && !_vm.bodyWrapperHeight) { | |
| _vm.bodyWrapperHeight = maxHeight | |
| } | |
| if (scrollYLoad && !_vm.bodyWrapperHeight && maxHeight) { | |
| _vm.bodyWrapperHeight = maxHeight | |
| } |
🤖 Prompt for AI Agents
In packages/vue/src/grid/src/table/src/utils/updateStyle.ts around lines 70 to
72, add a null or undefined check for maxHeight before assigning it to
_vm.bodyWrapperHeight. Modify the condition to ensure _vm.bodyWrapperHeight is
only set if maxHeight has a valid (non-null and non-undefined) value to prevent
assigning undefined and causing layout issues.
PR
修复当有横向滚动条时，虚拟滚动表格滚动到底部表头会多出滚动条偏移量的问题
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit