fix(grid): fix drag error when tbody not render #3538
Conversation
WalkthroughThe initialization logic for row and column drag-and-drop in the grid body component has been moved from a delayed execution within the Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/vue/src/grid/src/body/src/body.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/vue/src/grid/src/body/src/body.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*`: 用于写产品需求和开发文档的文件，需求应尽量写得简单清晰易懂。 在需求设计阶段应遵从逐步迭代的原则，早期版本可以尽量简洁。
**/*: 用于写产品需求和开发文档的文件，需求应尽量写得简单清晰易懂。
在需求设计阶段应遵从逐步迭代的原则，早期版本可以尽量简洁。
📄 Source: CodeRabbit Inference Engine (.cursor/rules/product.mdc)
List of files the instruction was applied to:
packages/vue/src/grid/src/body/src/body.tsx
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
| hooks.watch(tbody, (tbody) => { | ||
| if (tbody && $table.dropConfig) { | ||
| // 初始化行列拖拽 | ||
| const { plugin, row = true, column = true, scheme } = $table.dropConfig | ||
|
|
||
| plugin && row && (vm.rowSortable = $table.rowDrop(body.value)) | ||
|
|
||
| if (scheme !== 'v2') { | ||
| plugin && column && (vm.columnSortable = $table.columnDrop(body.value)) | ||
| } | ||
| } | ||
| }) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add cleanup logic to prevent memory leaks when tbody changes.
The implementation correctly fixes the timing issue by using a reactive watcher instead of setTimeout. However, since watchers can trigger multiple times, you should destroy existing sortable instances before creating new ones to prevent memory leaks.
Apply this diff to add proper cleanup:
hooks.watch(tbody, (tbody) => {
if (tbody && $table.dropConfig) {
+ // 清理之前的拖拽实例
+ if (vm.rowSortable) {
+ vm.rowSortable.destroy()
+ vm.rowSortable = null
+ }
+ if (vm.columnSortable) {
+ vm.columnSortable.destroy()
+ vm.columnSortable = null
+ }
+
// 初始化行列拖拽
const { plugin, row = true, column = true, scheme } = $table.dropConfig
plugin && row && (vm.rowSortable = $table.rowDrop(body.value))
if (scheme !== 'v2') {
plugin && column && (vm.columnSortable = $table.columnDrop(body.value))
}
}
})📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| hooks.watch(tbody, (tbody) => { | |
| if (tbody && $table.dropConfig) { | |
| // 初始化行列拖拽 | |
| const { plugin, row = true, column = true, scheme } = $table.dropConfig | |
| plugin && row && (vm.rowSortable = $table.rowDrop(body.value)) | |
| if (scheme !== 'v2') { | |
| plugin && column && (vm.columnSortable = $table.columnDrop(body.value)) | |
| } | |
| } | |
| }) | |
| hooks.watch(tbody, (tbody) => { | |
| if (tbody && $table.dropConfig) { | |
| // 清理之前的拖拽实例 | |
| if (vm.rowSortable) { | |
| vm.rowSortable.destroy() | |
| vm.rowSortable = null | |
| } | |
| if (vm.columnSortable) { | |
| vm.columnSortable.destroy() | |
| vm.columnSortable = null | |
| } | |
| // 初始化行列拖拽 | |
| const { plugin, row = true, column = true, scheme } = $table.dropConfig | |
| plugin && row && (vm.rowSortable = $table.rowDrop(body.value)) | |
| if (scheme !== 'v2') { | |
| plugin && column && (vm.columnSortable = $table.columnDrop(body.value)) | |
| } | |
| } | |
| }) |
🤖 Prompt for AI Agents
In packages/vue/src/grid/src/body/src/body.tsx around lines 753 to 764, the
watcher on tbody creates new sortable instances each time it triggers without
cleaning up previous instances, causing potential memory leaks. Modify the
watcher to first check if vm.rowSortable and vm.columnSortable exist and call
their destroy methods to clean up before assigning new sortable instances. This
ensures old instances are properly disposed before creating new ones.
PR
修复拖拽功能异常，修改初始化拖拽逻辑时机
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit