fix(cascader): fix When using slots in cascader-panel, the mf template will error #3537
Conversation
WalkthroughA comment was added in the renderless cascader node to clarify the usage of Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant MobileFirstCascader
participant RenderNodeLabel
User->>MobileFirstCascader: Request to render node label
alt nodeLabel is string
MobileFirstCascader->>User: Render label in <span>
else nodeLabel is vnode
MobileFirstCascader->>RenderNodeLabel: Pass vnode prop
RenderNodeLabel->>User: Render vnode content
end
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/vue/src/cascader-node/src/pc.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/renderless/src/cascader-node/vue.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/vue/src/cascader-node/src/mobile-first.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/vue/src/cascader-node/src/pc.vue (1)
122-123: Consider implementing the suggested simplification.The comment correctly identifies that
state.nodeLabelalready handles therenderLabelFnlogic, making the current manual check redundant.You could simplify this to:
-const renderContent = () => { - const { panel, node } = this - const render = panel.state.renderLabelFn - - const vnode = render ? render({ node, data: node.data }) : null - - // 可用 state.nodeLabel 简化 - return <span class="tiny-cascader-node__label">{vnode || node.label}</span> -} +const renderContent = () => { + return <span class="tiny-cascader-node__label">{this.state.nodeLabel}</span> +}packages/vue/src/cascader-node/src/mobile-first.vue (1)
19-24: Verify the class binding logic and reduce code duplication.Two potential issues in the conditional rendering:
- The class binding uses
nodewhich is always truthy (required prop), possibly should checkstate.isDisabledinstead- The same class logic is duplicated in both conditional spans
Consider refactoring to reduce duplication:
-<span v-if="typeof state.nodeLabel === 'string'" :class="[node ? gcls('cascader-node__label_disabled') : '']"> - {{ state.nodeLabel }} -</span> -<span v-else :class="[node ? gcls('cascader-node__label_disabled') : '']"> - <render-node-label :vnode="state.nodeLabel" /> -</span> +<span :class="[state.isDisabled ? gcls('cascader-node__label_disabled') : '']"> + <template v-if="typeof state.nodeLabel === 'string'"> + {{ state.nodeLabel }} + </template> + <render-node-label v-else :vnode="state.nodeLabel" /> +</span>Please verify if the class should be based on
state.isDisabledrather than the always-truthynodeprop.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/renderless/src/cascader-node/vue.ts(1 hunks)packages/vue/src/cascader-node/src/mobile-first.vue(2 hunks)packages/vue/src/cascader-node/src/pc.vue(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*`: 用于写产品需求和开发文档的文件，需求应尽量写得简单清晰易懂。 在需求设计阶段应遵从逐步迭代的原则，早期版本可以尽量简洁。
**/*: 用于写产品需求和开发文档的文件，需求应尽量写得简单清晰易懂。
在需求设计阶段应遵从逐步迭代的原则，早期版本可以尽量简洁。
📄 Source: CodeRabbit Inference Engine (.cursor/rules/product.mdc)
List of files the instruction was applied to:
packages/vue/src/cascader-node/src/pc.vuepackages/renderless/src/cascader-node/vue.tspackages/vue/src/cascader-node/src/mobile-first.vue
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (2)
packages/renderless/src/cascader-node/vue.ts (1)
48-48: LGTM! Good clarification comment.The comment helps clarify the specific usage context of
nodeLabelin the mobile-first implementation, improving code maintainability.packages/vue/src/cascader-node/src/mobile-first.vue (1)
52-59: Fix the functional component's Vue 2/3 compatibility logic.The current render function implementation has incorrect Vue version compatibility logic. In Vue 2,
his the createElement function (not an object with avnodeproperty), and in Vue 3, the first parameter isprops.Apply this diff to fix the compatibility:
-RenderNodeLabel: { - name: 'AnyNode', - functional: true, - props: ['vnode'], - render(h, ctx) { - return h.vnode || ctx.props?.vnode // 兼容vue2,3的写法 - } -} +RenderNodeLabel: { + name: 'AnyNode', + functional: true, + props: ['vnode'], + render(h, ctx) { + // Vue 2: h is createElement, props in ctx.props + // Vue 3: h is props, ctx is context + return (ctx && ctx.props) ? ctx.props.vnode : h.vnode + } +}Likely an incorrect or invalid review comment.
PR
修复 级联面板在使用插槽时， cascader-node的mf模板会报错的问题
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Style
Documentation