-
Notifications
You must be signed in to change notification settings - Fork 311
fix(grid): fix resize bar cover by header #3536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe z-index value for the resizable bar in the table grid styles was increased from 4 to 21 in two LESS files. This adjustment ensures the resizable bar appears above more elements in the stacking context. No other style properties or selectors were changed. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/theme-saas/src/grid/table.less (1)
709-711
: Z-index is hard-coded; move to a design token to avoid future driftThe bar now sits on
z-index: 21
, which is just one step above thez-20
scrollbar wrapper defined ~L1000. This solves the header–overlay issue, but sprinkling magic numbers makes cross-theme consistency brittle.Recommend introducing a shared variable, e.g.:
@grid-resize-bar-z: 21; // keep in variables.less &__resizable-bar { ... - @apply ~'z-[21]'; + @apply ~'z-[@{grid-resize-bar-z}]'; }packages/theme/src/grid/table.less (1)
639-642
: Duplicate hard-coded z-index – centralise with a variableSame concern as the SaaS theme:
z-index: 21
is repeated here. Consider reusing a single token (@grid-resize-bar-z
) for both themes to keep them in lock-step and avoid future mismatches.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/theme-saas/src/grid/table.less
(1 hunks)packages/theme/src/grid/table.less
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*`: 用于写产品需求和开发文档的文件,需求应尽量写得简单清晰易懂。 在需求设计阶段应遵从逐步迭代的原则,早期版本可以尽量简洁。
**/*
: 用于写产品需求和开发文档的文件,需求应尽量写得简单清晰易懂。
在需求设计阶段应遵从逐步迭代的原则,早期版本可以尽量简洁。
📄 Source: CodeRabbit Inference Engine (.cursor/rules/product.mdc)
List of files the instruction was applied to:
packages/theme/src/grid/table.less
packages/theme-saas/src/grid/table.less
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: PR Unit Test
- GitHub Check: PR E2E Test (pnpm test:e2e3)
PR
修复拖拽列宽线被表头遮挡问题
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit