-
Notifications
You must be signed in to change notification settings - Fork 311
fix(grid): fix grid scroll to bottom error when only set max-height #3531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA single CSS property, Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/theme/src/grid/table.less (1)
1255-1262
: Avoid style divergence – extract the shared ruleThe same
max-height: inherit;
patch now exists in both theme files.
To reduce maintenance cost and avoid future divergence, consider extracting this rule into a shared mixin (or reuse an existing one) and include it from the two theme bundles instead of duplicating raw lines.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/theme-saas/src/grid/table.less
(1 hunks)packages/theme/src/grid/table.less
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*`: 用于写产品需求和开发文档的文件,需求应尽量写得简单清晰易懂。 在需求设计阶段应遵从逐步迭代的原则,早期版本可以尽量简洁。
**/*
: 用于写产品需求和开发文档的文件,需求应尽量写得简单清晰易懂。
在需求设计阶段应遵从逐步迭代的原则,早期版本可以尽量简洁。
packages/theme/src/grid/table.less
packages/theme-saas/src/grid/table.less
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: PR Unit Test
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (1)
packages/theme-saas/src/grid/table.less (1)
1436-1443
: Ensure the newmax-height
actually propagates
max-height: inherit;
only has an effect when a finitemax-height
is defined on an ancestor.
Please confirm that the parent of.sticky-wrapper
(typically the body wrapper) sets an explicitmax-height
, otherwise this rule will be a no-op and the original scroll issue may remain unaddressed.
If the parent is expected to rely on inline styles calculated at runtime, consider adding a fallback (e.g., via a CSS variable) to guarantee determinism across themes/frame integrations.
PR
修复重构问题:当只配置了max-height时,滚动至底部表头消失
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information