feat(calendar-view): [calendar-view]add attributes #3525
Conversation
WalkthroughThe changes introduce a new boolean prop, Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
examples/sites/demos/apis/calendar-view.jsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. examples/sites/demos/pc/app/calendar-view/calendar-mode-composition-api.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. examples/sites/demos/pc/app/calendar-view/calendar-mode.spec.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/vue/src/calendar-view/src/pc.vue (1)
126-130: Consider avoiding unnecessary formatting changes.The formatting changes to the week-day span element don't add functional value and make the diff noisy. Consider keeping such formatting changes in separate commits.
examples/sites/demos/apis/calendar-view.js (1)
198-202: Documentation updates look good, but consider demo consistency.The API documentation correctly reflects the expanded support for PC mode and updated version. However, there's a potential inconsistency: the
defaultValueis documented as'true', but both demos explicitly set it tofalse. Consider whether the demos should demonstrate the default behavior (true) or if the default value documentation needs clarification.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
examples/sites/demos/apis/calendar-view.js(1 hunks)examples/sites/demos/pc/app/calendar-view/calendar-mode-composition-api.vue(1 hunks)examples/sites/demos/pc/app/calendar-view/calendar-mode.spec.ts(1 hunks)examples/sites/demos/pc/app/calendar-view/calendar-mode.vue(1 hunks)packages/vue/src/calendar-view/src/pc.vue(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (4)
packages/vue/src/calendar-view/src/pc.vue (2)
5-5: LGTM! Conditional rendering implemented correctly.The
v-if="showBackToday"directive properly controls the visibility of the "Back Today" button based on the new prop.
290-290: LGTM! Prop properly added to the props array.The
showBackTodayprop is correctly added to the component's props list.examples/sites/demos/pc/app/calendar-view/calendar-mode-composition-api.vue (1)
7-7: LGTM! Demo properly uses the new prop.The demo correctly demonstrates the
show-back-todayprop by explicitly setting it tofalse.examples/sites/demos/pc/app/calendar-view/calendar-mode.vue (1)
7-7: LGTM! Consistent usage across demos.The demo properly demonstrates the
show-back-todayprop, maintaining consistency with the composition API demo.
| @@ -9,6 +9,9 @@ test('显示模式', async ({ page }) => { | |||
| const dmonthDom = page.locator('.tiny-calendar-view-month__main') | |||
| const timelineDom = page.locator('.tiny-calendar-view-week__timeline') | |||
| const scheduleDom = page.locator('.tiny-calendar-view-week__schedule') | |||
|
|
|||
| const calendarHeader = page.locator('.tiny-calendar-view__header') | |||
| await expect(calendarHeader.locator('div').first()).not.toHaveClass('.tiny-button .tiny-button--default') | |||
There was a problem hiding this comment.
Fix the CSS selector syntax in the test assertion.
The selector .tiny-button .tiny-button--default uses descendant selector syntax (space-separated), but you likely want to check that the element doesn't have both classes. Consider using .tiny-button.tiny-button--default (dot-separated) or check for individual classes separately.
- await expect(calendarHeader.locator('div').first()).not.toHaveClass('.tiny-button .tiny-button--default')
+ await expect(calendarHeader.locator('div').first()).not.toHaveClass(/tiny-button/)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| await expect(calendarHeader.locator('div').first()).not.toHaveClass('.tiny-button .tiny-button--default') | |
| await expect(calendarHeader.locator('div').first()).not.toHaveClass(/tiny-button/) |
🤖 Prompt for AI Agents
In examples/sites/demos/pc/app/calendar-view/calendar-mode.spec.ts at line 14,
the CSS selector in the test assertion incorrectly uses a descendant selector
'.tiny-button .tiny-button--default' to check for classes on a single element.
Replace the selector with '.tiny-button.tiny-button--default' to correctly check
that the element does not have both classes simultaneously.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests