Skip to content

fix(grid): fix custom setting style error at mobile-first #3524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

fix(grid): fix custom setting style error at mobile-first #3524

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3490ba8
fix(grid): fix custom setting style error at mobile-first
gimmyhehe Jun 19, 2025
6a4a37d
docs: optimize docs
gimmyhehe Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/vue/src/grid-toolbar/src/custom-saas.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
<template>
<!-- 同步勿删，此处custom适配不了多端，因此需要固定Modal为pc端 -->
<tiny-modal
width="800"
tiny_mode="pc"
tiny_mode_root
Comment on lines +5 to +6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix prop naming for <tiny-modal> and verify support
Vue component props should use kebab-case in templates. The underscores here may not map to the intended props (tinyMode, tinyModeRoot) on the tiny-modal component and can silently break your fix. Please confirm that these props exist and work as expected, or apply the following diff:

 <tiny-modal
     width="800"
-    tiny_mode="pc"
-    tiny_mode_root
+    tiny-mode="pc"
+    tiny-mode-root
     title=" "
     class="tiny-grid-toolbar-modal"
     v-model="visible"
     @input="handleInput"
     @close="handleClose"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
tiny_mode="pc"
tiny_mode_root
<tiny-modal
width="800"
tiny-mode="pc"
tiny-mode-root
title=" "
class="tiny-grid-toolbar-modal"
v-model="visible"
@input="handleInput"
@close="handleClose"
>
🤖 Prompt for AI Agents 
In packages/vue/src/grid-toolbar/src/custom-saas.vue at lines 5 to 6, the props
for the <tiny-modal> component are incorrectly named using underscores instead
of kebab-case. Rename the props from tiny_mode and tiny_mode_root to tiny-mode
and tiny-mode-root respectively to match Vue's kebab-case convention for props
in templates. Also verify that these props exist on the tiny-modal component and
function correctly after renaming.

title=" "
class="tiny-grid-toolbar-modal"
v-model="visible"
Expand Down
Loading