feat: add svgs #3522
feat: add svgs #3522
Conversation
WalkthroughThree new Vue icon components—IconAcceptance, IconPaymentSlips, and IconPerformance—are introduced. These icons are implemented as new modules and integrated into both the Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/vue-icon/src/performance/index.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/vue-icon/index.ts (1)
14-14: Add import for IconAcceptance.The new import follows the established pattern. Consider inserting it in alphabetical order within the initial icon block (e.g. after
IconAdd, beforeIconAdministrator) to keep the import list consistent.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
packages/theme/src/svgs/acceptance.svgis excluded by!**/*.svgpackages/theme/src/svgs/payment-slips.svgis excluded by!**/*.svgpackages/theme/src/svgs/performance.svgis excluded by!**/*.svg
📒 Files selected for processing (5)
packages/vue-icon-saas/index.ts(6 hunks)packages/vue-icon/index.ts(6 hunks)packages/vue-icon/src/acceptance/index.ts(1 hunks)packages/vue-icon/src/payment-slips/index.ts(1 hunks)packages/vue-icon/src/performance/index.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (14)
packages/vue-icon/src/payment-slips/index.ts (1)
12-15: Add IconPaymentSlips module
The new component correctly imports the SVG asset and wraps it with the sharedsvghelper for consistency.packages/vue-icon/src/acceptance/index.ts (1)
12-15: Add IconAcceptance module
This follows the same pattern as other icons, importing the SVG and invoking thesvghelper.packages/vue-icon-saas/index.ts (6)
14-14: Register IconAcceptance import
ImportedIconAcceptancealongside existing modules to expose the new icon in the SaaS package.
515-517: Register IconPaymentSlips & IconPerformance imports
Both new icons are imported from their source modules to make them available downstream.
546-547: Export IconAcceptance as named export
AddsIconAcceptanceand its camelCase alias for consistency with other icons.
598-599: Export IconPaymentSlips as named export
Ensures external consumers can importIconPaymentSlipsandiconPaymentSlips.
602-603: Export IconPerformance as named export
Adds both PascalCase and camelCase exports for the new performance icon.
1598-1598: Include new icons in default export
IconAcceptance,IconPaymentSlips, andIconPerformanceare correctly added to the default export object.Also applies to: 1624-1624, 1626-1626
packages/vue-icon/index.ts (6)
1-2120: Missing integration intovue-icon-saasentrypoint.The AI summary indicates these icons should also be exposed in
packages/vue-icon-saas/index.ts, but this PR only updatespackages/vue-icon/index.ts. Please verify and, if needed, add matching imports and exports in thevue-icon-saaspackage entry point.Likely an incorrect or invalid review comment.
515-517: Add imports for IconPaymentSlips and IconPerformance.These imports correctly follow the existing naming conventions and file paths, and are placed in alphabetical order among the sync aui icon imports.
546-548: Expose IconAcceptance in named exports.The PascalCase export and its camelCase alias are correctly added to the named exports block.
598-600: Expose IconPaymentSlips in named exports.The new icon and its alias have been correctly inserted, matching the pattern of other named exports.
602-603: Expose IconPerformance in named exports.Correctly added both the PascalCase export and the camelCase alias.
1598-1599: Include new icons in default export.All three new icons (
IconAcceptance,IconPaymentSlips, andIconPerformance) are properly listed in the default export object, making them available for default imports.Also applies to: 1624-1626
PR
acceptance.svg/payment-slips.svg/performance.svgPR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit