fix(grid): Fix the table css in saas mode. #3520
Conversation
WalkthroughThe changes update various style properties across multiple components, focusing on padding, margin, background, and line height adjustments. These modifications refine the visual alignment and spacing of text, grid cells, buttons, dropdown items, and textarea count displays. No logic, control flow, or exported entity signatures were altered. Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/vue/src/button/src/token.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/vue/src/dropdown-item/src/mobile-first.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/vue/src/button/src/token.ts (1)
51-51: Consistent responsive utility prefixes for padding?
Theno-circlevariant appliespl-2 pr-2at all breakpoints, whereas theis-circlevariant usessm:pl-2 sm:pr-2. Please verify if the padding should indeed apply unconditionally or if it should be scoped to thesm:breakpoint for consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
packages/theme-saas/src/grid/mixins/table.less(2 hunks)packages/theme-saas/src/grid/table.less(0 hunks)packages/theme-saas/src/textarea/index.less(1 hunks)packages/vue/src/button/src/token.ts(1 hunks)packages/vue/src/dropdown-item/src/mobile-first.vue(1 hunks)
💤 Files with no reviewable changes (1)
- packages/theme-saas/src/grid/table.less
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (4)
packages/theme-saas/src/textarea/index.less (1)
51-53: Refine textarea character count positioning
Switching frombottom-1tobottom-0and addingleading-5aligns the count badge with the updated line-height and grid metrics. This change is consistent with our new spacing guidelines.packages/theme-saas/src/grid/mixins/table.less (2)
11-11: Increase left padding in text-ellipsis mixin
Updating frompl-2topl-4ensures better horizontal spacing and matches the new SaaS mode table layout.
38-39: Add right padding in CellEllipsis for balanced spacing
Applyingpr-4complements the left padding in.TextEllipsis()and prevents text from touching the cell edge.packages/vue/src/dropdown-item/src/mobile-first.vue (1)
15-15: Enforce margin-bottom override with important variant
Changing to[&:not(:last-of-type)]:!mb-1guarantees the spacing rule isn’t superseded by other styles in complex dropdown hierarchies.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/theme-saas/src/grid/filter.less (1)
10-10: Introduce left padding to the filter wrapper for alignment
The newpl-1utility brings the filter button in line with the grid’s updated spacing conventions. Consider checking narrow or fluid layouts to ensure it doesn’t cause unintended overflow.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
packages/theme-saas/src/grid/filter.less(1 hunks)packages/theme-saas/src/grid/header.less(0 hunks)packages/theme-saas/src/grid/mixins/table.less(2 hunks)packages/theme-saas/src/grid/table-global.less(1 hunks)packages/theme-saas/src/grid/table.less(1 hunks)packages/theme-saas/src/textarea/index.less(1 hunks)packages/vue/src/button/src/token.ts(1 hunks)packages/vue/src/dropdown-item/src/mobile-first.vue(1 hunks)
💤 Files with no reviewable changes (1)
- packages/theme-saas/src/grid/header.less
🚧 Files skipped from review as they are similar to previous changes (5)
- packages/vue/src/button/src/token.ts
- packages/vue/src/dropdown-item/src/mobile-first.vue
- packages/theme-saas/src/grid/table.less
- packages/theme-saas/src/textarea/index.less
- packages/theme-saas/src/grid/mixins/table.less
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (1)
packages/theme-saas/src/grid/table-global.less (1)
593-593: Add left padding to the sort wrapper in SaaS mode
Applyingpl-1here standardizes the horizontal spacing for the sort icons and removes the need for manual positioning offsets.
PR
fix:修复saas模式表格css
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit