-
Notifications
You must be signed in to change notification settings - Fork 310
feat: sync release-3.17.0 to dev #1801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* feat(drawer): [drawer] Add drag listening event * feat(drawer): [drawer] Modify version number
* feat(vue): [button-group] add empty slot * docs(button-group): add new api version
* fix: chart-core添加cloneDeep引入 * fix: 修改chart组件getFormatted函数判断逻辑 * fix: 更新chart-core包版本为3.17.1
* fix(popper): fix build error in vitepress * fix(popper): 升级版本
#1724) * fix(grid): [grid] change custom components to tinyvue components to adapt difference theme * Update package.json
…t lost props (#1740) * fix(select): the input parameter of the computedDisabledTooltipcontent does not contain props * fix(select): update version
* fix(breadcrumb): [breadcrumb] resolve delimiter issued * fix(breadcrumb): [breadcrumb] resolve delimiter issued
#1768) * fix(theme): when release theme, copy dist to _dist and replace cssvar's prefix name * fix(vue-theme): update package's version
WalkthroughThe recent changes involve version updates to two packages: Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BreadcrumbItem
participant ThemeBuilder
User->>BreadcrumbItem: Request Breadcrumb
BreadcrumbItem->>BreadcrumbItem: Compute Separator
BreadcrumbItem->>User: Render Breadcrumb
User->>ThemeBuilder: Trigger Build
ThemeBuilder->>ThemeBuilder: Process CSS/JS Files
ThemeBuilder->>User: Output Files
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- packages/renderless/package.json (1 hunks)
- packages/renderless/src/breadcrumb-item/vue.ts (1 hunks)
- packages/theme/build/release.js (1 hunks)
- packages/theme/package.json (4 hunks)
Files skipped from review due to trivial changes (2)
- packages/renderless/package.json
- packages/theme/package.json
Additional comments not posted (9)
packages/renderless/src/breadcrumb-item/vue.ts (3)
25-26
: Enhance reactivity by includingcomputed
.The addition of
computed
to the destructuredISharedRenderlessParamHooks
enhances the reactivity capabilities of the function.
26-26
: Streamline parameter handling by includingdesignConfig
.The inclusion of
designConfig
in the destructuredIBreadcrumbItemRenderlessParamUtils
streamlines the parameter handling.
33-33
: Improve reactivity with computedseparator
.Defining the
separator
as a computed property allows for dynamic updates based on changes inbreadcrumb
ordesignConfig
, ensuring that the UI remains responsive.packages/theme/build/release.js (6)
10-14
: Encapsulate file operations withreplaceFile
.The
replaceFile
function encapsulates file operations into a reusable function, enhancing the modularity and maintainability of the script.
17-17
: Generatelowcode.css
with prefix replacement.The
replaceFile
function is used to generatelowcode.css
by replacing the prefix inindex.css
.
20-22
: Copy and process files with consistent prefix replacement.The script copies and processes multiple files, ensuring consistent prefix replacement across various file types to avoid conflicts.
24-27
: Process allindex.css
files with prefix replacement.The script locates all
index.css
files within nested directories and applies the prefix replacement uniformly.
29-36
: Process JavaScript theme files with prefix replacement.The script processes JavaScript theme files, ensuring consistent prefix replacement across both CSS and JS files.
39-40
: Enhance completeness by copyingpackage.json
andREADME.md
.The script copies
package.json
andREADME.md
files into thedist
directory, enhancing the completeness of the output package.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
@opentiny/vue-renderless
to 3.17.6, enhancing performance and stability.@opentiny/vue-theme
for flexible file processing and improved file handling.Bug Fixes
tiny3
framework.Chores
package.json
for better clarity and usability, including new repository and bugs sections.